From aa29e00578a01768d1ee7bf537e5b2a335c46b30 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= <dach.bartlomiej@gmail.com>
Date: Tue, 22 Aug 2023 08:58:10 +0200
Subject: [PATCH] Remove `FlashTaskbar` and use `IsImportant` directly instead

---
 osu.Game/Overlays/NotificationOverlay.cs        | 4 ++--
 osu.Game/Overlays/Notifications/Notification.cs | 5 -----
 osu.Game/Screens/Play/PlayerLoader.cs           | 2 --
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/osu.Game/Overlays/NotificationOverlay.cs b/osu.Game/Overlays/NotificationOverlay.cs
index 6dd344ca99..b93d5f1e12 100644
--- a/osu.Game/Overlays/NotificationOverlay.cs
+++ b/osu.Game/Overlays/NotificationOverlay.cs
@@ -179,9 +179,9 @@ namespace osu.Game.Overlays
 
             playDebouncedSample(notification.PopInSampleName);
 
-            if (notification.FlashTaskbar)
+            if (notification.IsImportant)
             {
-                game?.Window?.Flash(notification.IsImportant);
+                game?.Window?.Flash();
                 notification.Closed += () => game?.Window?.CancelFlash();
             }
 
diff --git a/osu.Game/Overlays/Notifications/Notification.cs b/osu.Game/Overlays/Notifications/Notification.cs
index 53fc152c96..8cdc373417 100644
--- a/osu.Game/Overlays/Notifications/Notification.cs
+++ b/osu.Game/Overlays/Notifications/Notification.cs
@@ -38,11 +38,6 @@ namespace osu.Game.Overlays.Notifications
         /// </summary>
         public virtual bool IsImportant => true;
 
-        /// <summary>
-        /// Whether this notification should trigger a taskbar flash if the window is un-focused when posted.
-        /// </summary>
-        public bool FlashTaskbar { get; init; } = true;
-
         /// <summary>
         /// Run on user activating the notification. Return true to close.
         /// </summary>
diff --git a/osu.Game/Screens/Play/PlayerLoader.cs b/osu.Game/Screens/Play/PlayerLoader.cs
index eccfc4dc7b..872425e3fd 100644
--- a/osu.Game/Screens/Play/PlayerLoader.cs
+++ b/osu.Game/Screens/Play/PlayerLoader.cs
@@ -568,7 +568,6 @@ namespace osu.Game.Screens.Play
             public MutedNotification()
             {
                 Text = NotificationsStrings.GameVolumeTooLow;
-                FlashTaskbar = false;
             }
 
             [BackgroundDependencyLoader]
@@ -624,7 +623,6 @@ namespace osu.Game.Screens.Play
             public BatteryWarningNotification()
             {
                 Text = NotificationsStrings.BatteryLow;
-                FlashTaskbar = false;
             }
 
             [BackgroundDependencyLoader]