From a92b32f6dc94a164e5a2502e5f070240673f555e Mon Sep 17 00:00:00 2001
From: unknown <n20gaming2000@gmail.com>
Date: Tue, 5 Nov 2019 00:56:09 +0800
Subject: [PATCH] add basic tests

---
 .../TestSceneModCustomizationSettings.cs      | 108 ++++++++++++++++++
 osu.Game/Overlays/Mods/ModSelectOverlay.cs    |   8 +-
 2 files changed, 115 insertions(+), 1 deletion(-)
 create mode 100644 osu.Game.Tests/Visual/UserInterface/TestSceneModCustomizationSettings.cs

diff --git a/osu.Game.Tests/Visual/UserInterface/TestSceneModCustomizationSettings.cs b/osu.Game.Tests/Visual/UserInterface/TestSceneModCustomizationSettings.cs
new file mode 100644
index 0000000000..ec5b3c1e16
--- /dev/null
+++ b/osu.Game.Tests/Visual/UserInterface/TestSceneModCustomizationSettings.cs
@@ -0,0 +1,108 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using System.Linq;
+using osu.Framework.Allocation;
+using osu.Framework.Bindables;
+using osu.Framework.Graphics;
+using osu.Framework.Graphics.Containers;
+using osu.Game.Graphics.UserInterface;
+using osu.Game.Overlays.Mods;
+using osu.Game.Overlays.Settings;
+using osu.Game.Rulesets.Mods;
+
+namespace osu.Game.Tests.Visual.UserInterface
+{
+    public class TestSceneModCustomizationSettings : OsuTestScene
+    {
+        private TestModSelectOverlay modSelect;
+
+        [BackgroundDependencyLoader]
+        private void load()
+        {
+            Add(modSelect = new TestModSelectOverlay
+            {
+                RelativeSizeAxes = Axes.X,
+                Origin = Anchor.BottomCentre,
+                Anchor = Anchor.BottomCentre,
+            });
+
+            var testMod = new TestModCustomizable();
+
+            AddStep("open", modSelect.Show);
+            AddAssert("button disabled", () => !modSelect.CustomizeButton.Enabled.Value);
+            AddStep("select mod", () => modSelect.SelectMod(testMod));
+            AddAssert("button enabled", () => modSelect.CustomizeButton.Enabled.Value);
+            AddStep("open customization", () => modSelect.CustomizeButton.Click());
+            AddAssert("controls exist", () => modSelect.GetControlSection(testMod) != null);
+            AddStep("deselect mod", () => modSelect.SelectMod(testMod));
+            AddAssert("controls hidden", () => modSelect.ModSettingsContainer.Alpha == 0);
+        }
+
+        private class TestModSelectOverlay : ModSelectOverlay
+        {
+            public new Container ModSettingsContainer => base.ModSettingsContainer;
+            public new TriangleButton CustomizeButton => base.CustomizeButton;
+
+            public void SelectMod(Mod mod) =>
+                ModSectionsContainer.Children.Single((s) => s.ModType == mod.Type)
+                    .ButtonsContainer.OfType<ModButton>().Single(b => b.Mods.Any(m => m.GetType() == mod.GetType())).SelectNext(1);
+
+            public ModControlSection GetControlSection(Mod mod) =>
+                ModSettingsContent.Children.FirstOrDefault((s) => s.Mod == mod);
+
+            protected override void LoadComplete()
+            {
+                base.LoadComplete();
+
+                foreach (var section in ModSectionsContainer)
+                    if (section.ModType == ModType.Conversion)
+                        section.Mods = new Mod[] { new TestModCustomizable() };
+                    else
+                        section.Mods = new Mod[] { };
+            }
+        }
+
+        private class TestModCustomizable : Mod, IModHasSettings
+        {
+            public override string Name => "Customizable Mod";
+
+            public override string Acronym => "CM";
+
+            public override double ScoreMultiplier => 1.0;
+
+            public override ModType Type => ModType.Conversion;
+
+            public readonly BindableFloat sliderBindable = new BindableFloat
+            {
+                MinValue = 0,
+                MaxValue = 10,
+            };
+
+            public readonly BindableBool tickBindable = new BindableBool();
+
+            public Drawable[] CreateControls()
+            {
+                BindableFloat sliderControl = new BindableFloat();
+                BindableBool tickControl = new BindableBool();
+
+                sliderControl.BindTo(sliderBindable);
+                tickControl.BindTo(tickBindable);
+
+                return new Drawable[]
+                {
+                    new SettingsSlider<float>
+                    {
+                        LabelText = "Slider",
+                        Bindable = sliderControl
+                    },
+                    new SettingsCheckbox
+                    {
+                        LabelText = "Checkbox",
+                        Bindable = tickControl
+                    }
+                };
+            }
+        }
+    }
+}
\ No newline at end of file
diff --git a/osu.Game/Overlays/Mods/ModSelectOverlay.cs b/osu.Game/Overlays/Mods/ModSelectOverlay.cs
index a344bcc254..fc5ed1b3f3 100644
--- a/osu.Game/Overlays/Mods/ModSelectOverlay.cs
+++ b/osu.Game/Overlays/Mods/ModSelectOverlay.cs
@@ -331,6 +331,7 @@ namespace osu.Game.Overlays.Mods
 
             SelectedMods.ValueChanged += updateModSettings;
             Ruleset.ValueChanged += _ => ModSettingsContent.Clear();
+            CustomizeButton.Enabled.Value = false;
 
             sampleOn = audio.Samples.Get(@"UI/check-on");
             sampleOff = audio.Samples.Get(@"UI/check-off");
@@ -344,7 +345,12 @@ namespace osu.Game.Overlays.Mods
             if (added is IModHasSettings)
                 ModSettingsContent.Add(new ModControlSection(added));
             else if (removed is IModHasSettings)
-                ModSettingsContent.Remove(ModSettingsContent.Children.Where(section => section.Mod == removed).FirstOrDefault());
+                ModSettingsContent.Remove(ModSettingsContent.Children.Where(section => section.Mod == removed).Single());
+
+            CustomizeButton.Enabled.Value = ModSettingsContent.Children.Count > 0;
+
+            if (ModSettingsContainer.Alpha == 1 && ModSettingsContent.Children.Count == 0)
+                ModSettingsContainer.Alpha = 0;
         }
 
         public void DeselectAll()