h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 21:02:55 +08:00
Code Issues Releases Wiki Activity

Expose update ternary state method and use better state determination function

Browse Source
This commit is contained in:
Dean Herbert 2020-09-25 15:27:45 +09:00
parent 50290f3cb4
commit a859fe78ee
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs
View File

@ -366,32 +366,32 @@ namespace osu.Game.Screens.Edit.Compose.Components
}; };
// bring in updates from selection changes // bring in updates from selection changes
EditorBeatmap.HitObjectUpdated += _ => updateTernaryStates(); EditorBeatmap.HitObjectUpdated += _ => UpdateTernaryStates();
EditorBeatmap.SelectedHitObjects.CollectionChanged += (sender, args) => updateTernaryStates(); EditorBeatmap.SelectedHitObjects.CollectionChanged += (sender, args) => UpdateTernaryStates();
} }
private void updateTernaryStates() /// <summary>
/// Called when context menu ternary states may need to be recalculated (selection changed or hitobject updated).
/// </summary>
protected virtual void UpdateTernaryStates()
{ {
selectionNewComboState.Value = getStateFromBlueprints(selectedBlueprints.Select(b => (IHasComboInformation)b.HitObject).Count(h => h.NewCombo)); selectionNewComboState.Value = GetStateFromSelection(SelectedHitObjects.OfType<IHasComboInformation>(), h => h.NewCombo);
foreach (var (sampleName, bindable) in selectionSampleStates) foreach (var (sampleName, bindable) in selectionSampleStates)
{ {
bindable.Value = getStateFromBlueprints(SelectedHitObjects.Count(h => h.Samples.Any(s => s.Name == sampleName))); bindable.Value = GetStateFromSelection(SelectedHitObjects, h => h.Samples.Any(s => s.Name == sampleName));
} }
} }
/// <summary> /// <summary>
/// Given a count of "true" blueprints, retrieve the correct ternary display state. /// Given a selection target and a function of truth, retrieve the correct ternary state for display.
/// </summary> /// </summary>
private TernaryState getStateFromBlueprints(int count) protected TernaryState GetStateFromSelection<T>(IEnumerable<T> selection, Func<T, bool> func)
{ {
if (count == 0) if (selection.Any(func))
return TernaryState.False; return selection.All(func) ? TernaryState.True : TernaryState.Indeterminate;
if (count < SelectedHitObjects.Count()) return TernaryState.False;
return TernaryState.Indeterminate;
return TernaryState.True;
} }
#endregion #endregion