h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-08 04:32:54 +08:00
Code Issues Releases Wiki Activity

Revert hacky fade value and fix test

Browse Source
This commit is contained in:
Joppe27 2022-12-01 12:16:58 +01:00
parent f9a9ab1d9b
commit a7f4325d3c
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game.Rulesets.Taiko.Tests/Skinning/TestSceneTaikoKiaiGlow.cs
View File

@ -21,6 +21,8 @@ namespace osu.Game.Rulesets.Taiko.Tests.Skinning
{ {
var controlPointInfo = new ControlPointInfo(); var controlPointInfo = new ControlPointInfo();
controlPointInfo.Add(0, new TimingControlPoint { BeatLength = 500 });
if (withKiai) if (withKiai)
controlPointInfo.Add(0, new EffectControlPoint { KiaiMode = true }); controlPointInfo.Add(0, new EffectControlPoint { KiaiMode = true });
@ -28,6 +30,8 @@ namespace osu.Game.Rulesets.Taiko.Tests.Skinning
{ {
ControlPointInfo = controlPointInfo ControlPointInfo = controlPointInfo
}); });
Beatmap.Value.Track.Start();
} }
} }
} }

4
osu.Game.Rulesets.Taiko/Skinning/Legacy/LegacyKiaiGlow.cs
View File

@ -16,8 +16,6 @@ namespace osu.Game.Rulesets.Taiko.Skinning.Legacy
{ {
internal partial class LegacyKiaiGlow : BeatSyncedContainer internal partial class LegacyKiaiGlow : BeatSyncedContainer
{ {
private const float colour_compensation = 1.58f;
public LegacyKiaiGlow() public LegacyKiaiGlow()
{ {
AlwaysPresent = true; AlwaysPresent = true;
@ -60,7 +58,7 @@ namespace osu.Game.Rulesets.Taiko.Skinning.Legacy
protected override void OnNewBeat(int beatIndex, TimingControlPoint timingPoint, EffectControlPoint effectPoint, ChannelAmplitudes amplitudes) protected override void OnNewBeat(int beatIndex, TimingControlPoint timingPoint, EffectControlPoint effectPoint, ChannelAmplitudes amplitudes)
{ {
if (effectPoint.KiaiMode) if (effectPoint.KiaiMode)
this.FadeTo(colour_compensation, 180); this.FadeIn(180);
else else
this.FadeOut(180); this.FadeOut(180);
} }