From a682a823f43f58857ff7c2c9973be6c48f52b9c9 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Fri, 5 Aug 2022 18:14:30 +0900
Subject: [PATCH] Fix test failures where `Beatmap` is not provided

---
 osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs b/osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs
index edfa92e629..ff79c917cb 100644
--- a/osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs
+++ b/osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs
@@ -122,21 +122,24 @@ namespace osu.Game.Rulesets.Osu.UI
 
             RegisterPool<HitCircle, DrawableHitCircle>(20, 100);
 
-            var sliders = osuBeatmap.HitObjects.OfType<Slider>();
+            int maxRepeatsOnOneSlider = 0;
+            int maxTicksOnOneSlider = 0;
 
-            if (sliders.Any())
+            var sliders = osuBeatmap?.HitObjects.OfType<Slider>();
+
+            if (sliders?.Any() == true)
             {
                 // handle edge cases where a beatmap has a slider with many repeats.
-                int maxRepeatsOnOneSlider = osuBeatmap.HitObjects.OfType<Slider>().Max(s => s.RepeatCount);
-                int maxTicksOnOneSlider = osuBeatmap.HitObjects.OfType<Slider>().Max(s => s.NestedHitObjects.OfType<SliderTick>().Count());
-
-                RegisterPool<Slider, DrawableSlider>(20, 100);
-                RegisterPool<SliderHeadCircle, DrawableSliderHead>(20, 100);
-                RegisterPool<SliderTailCircle, DrawableSliderTail>(20, 100);
-                RegisterPool<SliderTick, DrawableSliderTick>(Math.Max(maxTicksOnOneSlider, 20), Math.Max(maxTicksOnOneSlider, 200));
-                RegisterPool<SliderRepeat, DrawableSliderRepeat>(Math.Max(maxRepeatsOnOneSlider, 20), Math.Max(maxRepeatsOnOneSlider, 200));
+                maxRepeatsOnOneSlider = sliders?.Max(s => s.RepeatCount) ?? 0;
+                maxTicksOnOneSlider = sliders?.Max(s => s.NestedHitObjects.OfType<SliderTick>().Count()) ?? 0;
             }
 
+            RegisterPool<Slider, DrawableSlider>(20, 100);
+            RegisterPool<SliderHeadCircle, DrawableSliderHead>(20, 100);
+            RegisterPool<SliderTailCircle, DrawableSliderTail>(20, 100);
+            RegisterPool<SliderTick, DrawableSliderTick>(Math.Max(maxTicksOnOneSlider, 20), Math.Max(maxTicksOnOneSlider, 200));
+            RegisterPool<SliderRepeat, DrawableSliderRepeat>(Math.Max(maxRepeatsOnOneSlider, 20), Math.Max(maxRepeatsOnOneSlider, 200));
+
             RegisterPool<Spinner, DrawableSpinner>(2, 20);
             RegisterPool<SpinnerTick, DrawableSpinnerTick>(10, 200);
             RegisterPool<SpinnerBonusTick, DrawableSpinnerBonusTick>(10, 200);