h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 14:32:55 +08:00
Code Issues Releases Wiki Activity

Use switch—case instead

Browse Source
This commit is contained in:
Salman Ahmed 2021-05-19 23:37:22 +03:00
parent e20c25b0d9
commit a4d52a7f52
1 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
osu.Game.Rulesets.Catch/Skinning/Legacy/CatchLegacySkinTransformer.cs
View File

@ -24,19 +24,25 @@ namespace osu.Game.Rulesets.Catch.Skinning.Legacy
public override Drawable GetDrawableComponent(ISkinComponent component)
{
if (component is SkinnableTargetComponent targetComponent && targetComponent.Target == SkinnableTarget.MainHUDComponents)
if (component is SkinnableTargetComponent targetComponent)
{
if (!providesComboCounter)
return null;
if (Source.GetDrawableComponent(component) is SkinnableTargetComponentsContainer components)
switch (targetComponent.Target)
{
// catch may provide its own combo counter; hide the default.
// todo: this should be done in an elegant way per ruleset, defining which HUD skin components should be displayed.
foreach (var legacyComboCounter in components.OfType<LegacyComboCounter>())
legacyComboCounter.ContentVisible = false;
case SkinnableTarget.MainHUDComponents:
if (!providesComboCounter)
break;
return components;
if (Source.GetDrawableComponent(component) is SkinnableTargetComponentsContainer components)
{
// catch may provide its own combo counter; hide the default.
// todo: this should be done in an elegant way per ruleset, defining which HUD skin components should be displayed.
foreach (var legacyComboCounter in components.OfType<LegacyComboCounter>())
legacyComboCounter.ContentVisible = false;
return components;
}
break;
}
return null;