From a47d34f1db3ef3f69be44b0194630b06ebefda84 Mon Sep 17 00:00:00 2001
From: Shivam <s.r.v.ramkisoen@umail.leidenuniv.nl>
Date: Tue, 23 Jun 2020 23:34:26 +0200
Subject: [PATCH] make ignore properties protected virtual get-only in base

---
 .../NonVisual/CustomDataDirectoryTest.cs      |  5 +++--
 osu.Game/IO/MigratableStorage.cs              | 11 +++-------
 osu.Game/IO/OsuStorage.cs                     | 20 +++++++++++++++++++
 3 files changed, 26 insertions(+), 10 deletions(-)

diff --git a/osu.Game.Tests/NonVisual/CustomDataDirectoryTest.cs b/osu.Game.Tests/NonVisual/CustomDataDirectoryTest.cs
index 5abefe3198..5278837073 100644
--- a/osu.Game.Tests/NonVisual/CustomDataDirectoryTest.cs
+++ b/osu.Game.Tests/NonVisual/CustomDataDirectoryTest.cs
@@ -126,6 +126,7 @@ namespace osu.Game.Tests.NonVisual
                 {
                     var osu = loadOsu(host);
                     var storage = osu.Dependencies.Get<Storage>();
+                    var osuStorage = storage as OsuStorage;
 
                     // ensure we perform a save
                     host.Dependencies.Get<FrameworkConfigManager>().Save();
@@ -151,13 +152,13 @@ namespace osu.Game.Tests.NonVisual
                     Assert.That(!host.Storage.ExistsDirectory(Path.Combine("test-nested", "cache")));
                     Assert.That(storage.ExistsDirectory(Path.Combine("test-nested", "cache")));
 
-                    foreach (var file in MigratableStorage.IGNORE_FILES)
+                    foreach (var file in osuStorage.IGNORE_FILES)
                     {
                         Assert.That(host.Storage.Exists(file), Is.True);
                         Assert.That(storage.Exists(file), Is.False);
                     }
 
-                    foreach (var dir in MigratableStorage.IGNORE_DIRECTORIES)
+                    foreach (var dir in osuStorage.IGNORE_DIRECTORIES)
                     {
                         Assert.That(host.Storage.ExistsDirectory(dir), Is.True);
                         Assert.That(storage.ExistsDirectory(dir), Is.False);
diff --git a/osu.Game/IO/MigratableStorage.cs b/osu.Game/IO/MigratableStorage.cs
index c4dc4bcfb2..0656e61f10 100644
--- a/osu.Game/IO/MigratableStorage.cs
+++ b/osu.Game/IO/MigratableStorage.cs
@@ -14,14 +14,9 @@ namespace osu.Game.IO
     /// </summary>
     public abstract class MigratableStorage : WrappedStorage
     {
-        internal static readonly string[] IGNORE_DIRECTORIES = { "cache" };
-
-        internal static readonly string[] IGNORE_FILES =
-        {
-            "framework.ini",
-            "storage.ini"
-        };
-
+        internal virtual string[] IGNORE_DIRECTORIES { get; }
+        internal virtual string[] IGNORE_FILES { get; }
+        
         protected MigratableStorage(Storage storage, string subPath = null)
             : base(storage, subPath)
         {
diff --git a/osu.Game/IO/OsuStorage.cs b/osu.Game/IO/OsuStorage.cs
index 3d224841f3..bbec6eb575 100644
--- a/osu.Game/IO/OsuStorage.cs
+++ b/osu.Game/IO/OsuStorage.cs
@@ -14,6 +14,26 @@ namespace osu.Game.IO
         private readonly GameHost host;
         private readonly StorageConfigManager storageConfig;
 
+        internal override string[] IGNORE_DIRECTORIES
+        {
+            get
+            {
+                return new string[] { "cache" };
+            }
+        }
+
+        internal override string[] IGNORE_FILES
+        {
+            get
+            {
+                return new string[]
+                {
+                    "framework.ini",
+                    "storage.ini"
+                };
+            }
+        }
+
         public OsuStorage(GameHost host)
             : base(host.Storage, string.Empty)
         {