From 9f665cbf115d6bc336b5ed60697118a4d601a239 Mon Sep 17 00:00:00 2001 From: Austin Moore Date: Tue, 31 Mar 2026 07:42:10 +0000 Subject: [PATCH] Replace MacOS hitsound composer "Alt" text tooltip with "Opt". (#37156) - Closes https://github.com/ppy/osu/issues/37055 In the editor, keybinds and the tooltip for the hitsounding section are hardcoded. Since the keybind contains "Alt", this is inconsistent on MacOS where "Opt" is used instead. Before: image After (MacOS only): image --------- Co-authored-by: Dean Herbert --- osu.Game/Rulesets/Edit/HitObjectComposer.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/osu.Game/Rulesets/Edit/HitObjectComposer.cs b/osu.Game/Rulesets/Edit/HitObjectComposer.cs index c138808890..84b786c45a 100644 --- a/osu.Game/Rulesets/Edit/HitObjectComposer.cs +++ b/osu.Game/Rulesets/Edit/HitObjectComposer.cs @@ -14,6 +14,7 @@ using osu.Framework.Graphics; using osu.Framework.Graphics.Containers; using osu.Framework.Graphics.Shapes; using osu.Framework.Input; +using osu.Framework.Input.Bindings; using osu.Framework.Input.Events; using osu.Framework.Logging; using osu.Framework.Testing; @@ -106,7 +107,7 @@ namespace osu.Game.Rulesets.Edit dependencies = new DependencyContainer(base.CreateChildDependencies(parent)); [BackgroundDependencyLoader(true)] - private void load(OsuConfigManager config, [CanBeNull] Editor editor) + private void load(OsuConfigManager config, [CanBeNull] Editor editor, ReadableKeyCombinationProvider keyCombinationProvider) { autoSeekOnPlacement = config.GetBindable(OsuSetting.EditorAutoSeekOnPlacement); @@ -135,6 +136,9 @@ namespace osu.Game.Rulesets.Edit dependencies.CacheAs(Playfield); + string shiftDisplay = keyCombinationProvider.GetReadableString(new KeyCombination(InputKey.Shift)); + string altDisplay = keyCombinationProvider.GetReadableString(new KeyCombination(InputKey.Alt)); + InternalChildren = new[] { PlayfieldContentContainer = new Container @@ -180,7 +184,7 @@ namespace osu.Game.Rulesets.Edit Spacing = new Vector2(0, 5), }, }, - new EditorToolboxGroup("bank (Shift/Alt-Q~R)") + new EditorToolboxGroup($"bank ({shiftDisplay}/{altDisplay}-Q~R)") { Child = new FillFlowContainer {