From 9f3013e2c89a1ea018008cb6221d9165e72f13a2 Mon Sep 17 00:00:00 2001
From: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat, 7 Aug 2021 19:30:12 +0300
Subject: [PATCH] Remove all `HorizontalScreenOffset` calculations from
 overlays

---
 osu.Game/Overlays/NotificationOverlay.cs | 5 -----
 osu.Game/Overlays/SettingsOverlay.cs     | 2 --
 osu.Game/Overlays/SettingsPanel.cs       | 5 -----
 3 files changed, 12 deletions(-)

diff --git a/osu.Game/Overlays/NotificationOverlay.cs b/osu.Game/Overlays/NotificationOverlay.cs
index cb5d4d57c6..e3956089c2 100644
--- a/osu.Game/Overlays/NotificationOverlay.cs
+++ b/osu.Game/Overlays/NotificationOverlay.cs
@@ -30,11 +30,6 @@ namespace osu.Game.Overlays
 
         private FlowContainer<NotificationSection> sections;
 
-        /// <summary>
-        /// A horizontal offset to apply to the game-wide screen.
-        /// </summary>
-        public float HorizontalScreenOffset => -WIDTH + X;
-
         /// <summary>
         /// Provide a source for the toolbar height.
         /// </summary>
diff --git a/osu.Game/Overlays/SettingsOverlay.cs b/osu.Game/Overlays/SettingsOverlay.cs
index 9ed1d950e3..050502b3be 100644
--- a/osu.Game/Overlays/SettingsOverlay.cs
+++ b/osu.Game/Overlays/SettingsOverlay.cs
@@ -21,8 +21,6 @@ namespace osu.Game.Overlays
         public LocalisableString Title => SettingsStrings.HeaderTitle;
         public LocalisableString Description => SettingsStrings.HeaderDescription;
 
-        public override float HorizontalScreenOffset => base.HorizontalScreenOffset + (lastOpenedSubPanel?.HorizontalScreenOffset ?? 0f);
-
         protected override IEnumerable<SettingsSection> CreateSections() => new SettingsSection[]
         {
             new GeneralSection(),
diff --git a/osu.Game/Overlays/SettingsPanel.cs b/osu.Game/Overlays/SettingsPanel.cs
index 79d78e6805..64c3be4b9a 100644
--- a/osu.Game/Overlays/SettingsPanel.cs
+++ b/osu.Game/Overlays/SettingsPanel.cs
@@ -40,11 +40,6 @@ namespace osu.Game.Overlays
         /// </summary>
         public override bool IsPresent => true;
 
-        /// <summary>
-        /// A horizontal offset to apply to the game-wide screen.
-        /// </summary>
-        public virtual float HorizontalScreenOffset => (WIDTH + Content?.X) ?? 0f;
-
         protected Sidebar Sidebar;
         private SidebarButton selectedSidebarButton;