From 9e78a6b34e0deb25a4933b14d14f16cd91165bfd Mon Sep 17 00:00:00 2001
From: OliBomby <olivierschipper@gmail.com>
Date: Wed, 31 May 2023 20:00:45 +0200
Subject: [PATCH] hide addition bank field when no additions active

---
 .../Compose/Components/Timeline/SamplePointPiece.cs  | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/osu.Game/Screens/Edit/Compose/Components/Timeline/SamplePointPiece.cs b/osu.Game/Screens/Edit/Compose/Components/Timeline/SamplePointPiece.cs
index bbc5380e70..37a6fa8a22 100644
--- a/osu.Game/Screens/Edit/Compose/Components/Timeline/SamplePointPiece.cs
+++ b/osu.Game/Screens/Edit/Compose/Components/Timeline/SamplePointPiece.cs
@@ -180,6 +180,7 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
 
                 updateAdditionBankPlaceholderText();
                 updateAdditionBankText();
+                updateAdditionBankActivated();
                 additionBank.Current.BindValueChanged(val =>
                 {
                     updateAdditionBank(val.NewValue);
@@ -262,6 +263,15 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
                 additionBank.PlaceholderText = string.IsNullOrEmpty(commonAdditionBank) ? "(multiple)" : string.Empty;
             }
 
+            private void updateAdditionBankActivated()
+            {
+                bool anyAdditions = relevantSamples.Any(o => o.Any(s => s.Name != HitSampleInfo.HIT_NORMAL));
+                if (anyAdditions)
+                    additionBank.Show();
+                else
+                    additionBank.Hide();
+            }
+
             private void updateAdditionBankText()
             {
                 if (additionBank.Current.Disabled) return;
@@ -347,6 +357,7 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
                     samples.Add(relevantSample?.With(sampleName) ?? h.CreateHitSampleInfo(sampleName));
                 });
 
+                updateAdditionBankActivated();
                 updateAdditionBankText();
             }
 
@@ -365,6 +376,7 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
                 });
 
                 updateAdditionBankText();
+                updateAdditionBankActivated();
             }
 
             protected override bool OnKeyDown(KeyDownEvent e)