Move test to a mod test and add more resilient test logic

osu.Game.Rulesets.Osu.Tests/Mods/TestSceneOsuModAutopilot.cs

@@ -3,26 +3,23 @@
 
 using NUnit.Framework;
 using osu.Game.Rulesets.Osu.Mods;
-using osu.Game.Tests.Visual;
 using osuTK.Input;
 
-namespace osu.Game.Rulesets.Osu.Tests
+namespace osu.Game.Rulesets.Osu.Tests.Mods
 {
-    public partial class TestSceneInstantResume : TestSceneOsuPlayer
+    public partial class TestSceneOsuModAutopilot : OsuModTestScene
     {
-        protected override bool HasCustomSteps => true;
-
-        protected override TestPlayer CreatePlayer(Ruleset ruleset)
-        {
-            SelectedMods.Value = new[] { new OsuModAutopilot() };
-            return new TestPlayer();
-        }
-
         [Test]
         public void TestInstantResume()
         {
-            CreateTest();
+            CreateModTest(new ModTestData
+            {
+                Mod = new OsuModAutopilot(),
+                PassCondition = () => true,
+                Autoplay = false,
+            });
 
+            AddUntilStep("wait for gameplay start", () => Player.LocalUserPlaying.Value);
             AddStep("press pause", () => InputManager.PressKey(Key.Escape));
             AddUntilStep("wait until paused", () => Player.GameplayClockContainer.IsPaused.Value);
             AddStep("release pause", () => InputManager.ReleaseKey(Key.Escape));

osu.Game/Tests/Visual/ModTestScene.cs

@@ -66,7 +66,7 @@ namespace osu.Game.Tests.Visual
             protected override bool CheckModsAllowFailure() => allowFail;
 
             public ModTestPlayer(ModTestData data, bool allowFail)
-                : base(false, false)
+                : base(true, false)
             {
                 this.allowFail = allowFail;
                 currentTestData = data;