mirror of
https://github.com/ppy/osu.git
synced 2024-11-11 12:57:36 +08:00
Corrected the return values for taiko DrawableHit and DrawableHitStrong (OnPressed == true if new Judgement occurs and is a hit)
This commit is contained in:
parent
61a6a2919e
commit
9d3d9bcdc8
@ -67,7 +67,8 @@ namespace osu.Game.Rulesets.Taiko.Objects.Drawables
|
||||
{
|
||||
validKeyPressed = HitActions.Contains(action);
|
||||
|
||||
return UpdateJudgement(true);
|
||||
// Only count this as handled if the new judgement is a hit
|
||||
return UpdateJudgement(true) && Judgements.Last().IsHit;
|
||||
}
|
||||
|
||||
protected override void Update()
|
||||
|
@ -83,7 +83,7 @@ namespace osu.Game.Rulesets.Taiko.Objects.Drawables
|
||||
return false;
|
||||
|
||||
// Assume the intention was to hit the strong hit with both keys only if the first key is still being held down
|
||||
return firstKeyHeld && UpdateJudgement(true);
|
||||
return firstKeyHeld && Judgements.Last().IsHit;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user