h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 10:47:28 +08:00
Code Issues Releases Wiki Activity

Simplify conditionals to one XOR operations with comments

Browse Source
This commit is contained in:
Salman Ahmed 2022-03-14 04:40:24 +03:00
parent 0b8c89bfa8
commit 9cf05080da
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Storyboards/Drawables/DrawableStoryboardSprite.cs
View File

@ -79,7 +79,8 @@ namespace osu.Game.Storyboards.Drawables
{ {
var origin = base.Origin; var origin = base.Origin;
if ((FlipH || VectorScale.X < 0) && !(FlipH && VectorScale.X < 0)) // Either flip horizontally or negative X scale, but not both.
if (FlipH ^ (VectorScale.X < 0))
{ {
if (origin.HasFlagFast(Anchor.x0)) if (origin.HasFlagFast(Anchor.x0))
origin = Anchor.x2 | (origin & (Anchor.y0 | Anchor.y1 | Anchor.y2)); origin = Anchor.x2 | (origin & (Anchor.y0 | Anchor.y1 | Anchor.y2));
@ -87,7 +88,8 @@ namespace osu.Game.Storyboards.Drawables
origin = Anchor.x0 | (origin & (Anchor.y0 | Anchor.y1 | Anchor.y2)); origin = Anchor.x0 | (origin & (Anchor.y0 | Anchor.y1 | Anchor.y2));
} }
if ((FlipV || VectorScale.Y < 0) && !(FlipV && VectorScale.Y < 0)) // Either flip vertically or negative Y scale, but not both.
if (FlipV ^ (VectorScale.Y < 0))
{ {
if (origin.HasFlagFast(Anchor.y0)) if (origin.HasFlagFast(Anchor.y0))
origin = Anchor.y2 | (origin & (Anchor.x0 | Anchor.x1 | Anchor.x2)); origin = Anchor.y2 | (origin & (Anchor.x0 | Anchor.x1 | Anchor.x2));