From 9cdb3fe6aebf4ea994ec713c9770538499b141b5 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Fri, 4 Apr 2025 19:31:28 +0900 Subject: [PATCH] Remove obsoleted `ScrollTime` setting --- .../Configuration/ManiaRulesetConfigManager.cs | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/osu.Game.Rulesets.Mania/Configuration/ManiaRulesetConfigManager.cs b/osu.Game.Rulesets.Mania/Configuration/ManiaRulesetConfigManager.cs index 5242b6685c..b999a521d5 100644 --- a/osu.Game.Rulesets.Mania/Configuration/ManiaRulesetConfigManager.cs +++ b/osu.Game.Rulesets.Mania/Configuration/ManiaRulesetConfigManager.cs @@ -1,7 +1,6 @@ // Copyright (c) ppy Pty Ltd . Licensed under the MIT Licence. // See the LICENCE file in the repository root for full licence text. -using System; using osu.Framework.Configuration.Tracking; using osu.Game.Configuration; using osu.Game.Localisation; @@ -25,17 +24,6 @@ namespace osu.Game.Rulesets.Mania.Configuration SetDefault(ManiaRulesetSetting.ScrollDirection, ManiaScrollingDirection.Down); SetDefault(ManiaRulesetSetting.TimingBasedNoteColouring, false); SetDefault(ManiaRulesetSetting.MobileLayout, ManiaMobileLayout.Portrait); - -#pragma warning disable CS0618 - // Although obsolete, this is still required to populate the bindable from the database in case migration is required. - SetDefault(ManiaRulesetSetting.ScrollTime, null); - - if (Get(ManiaRulesetSetting.ScrollTime) is double scrollTime) - { - SetValue(ManiaRulesetSetting.ScrollSpeed, Math.Round(DrawableManiaRuleset.MAX_TIME_RANGE / scrollTime)); - SetValue(ManiaRulesetSetting.ScrollTime, null); - } -#pragma warning restore CS0618 } public override TrackedSettings CreateTrackedSettings() => new TrackedSettings @@ -52,8 +40,6 @@ namespace osu.Game.Rulesets.Mania.Configuration public enum ManiaRulesetSetting { - [Obsolete("Use ScrollSpeed instead.")] // Can be removed 2023-11-30 - ScrollTime, ScrollSpeed, ScrollDirection, TimingBasedNoteColouring,