h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-09-21 22:07:25 +08:00
Code Issues Releases Wiki Activity

Make getMod() method generally better

Browse Source
This commit is contained in:
Bartłomiej Dach 2023-05-04 19:12:22 +02:00
parent aa7885ab97
commit 99e8b2ce70
No known key found for this signature in database
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game.Tests/Visual/UserInterface/TestSceneModSelectOverlay.cs
View File

@ -387,7 +387,7 @@ namespace osu.Game.Tests.Visual.UserInterface
AddStep("change mod settings", () => AddStep("change mod settings", () =>
{ {
var osuMod = getMod<OsuModDifficultyAdjust>(); var osuMod = getSelectedMod<OsuModDifficultyAdjust>();
osuMod.ExtendedLimits.Value = true; osuMod.ExtendedLimits.Value = true;
osuMod.CircleSize.Value = setting_change; osuMod.CircleSize.Value = setting_change;
@ -401,7 +401,7 @@ namespace osu.Game.Tests.Visual.UserInterface
AddAssert("shared settings preserved", () => AddAssert("shared settings preserved", () =>
{ {
var taikoMod = getMod<TaikoModDifficultyAdjust>(); var taikoMod = getSelectedMod<TaikoModDifficultyAdjust>();
return taikoMod.ExtendedLimits.Value && return taikoMod.ExtendedLimits.Value &&
taikoMod.DrainRate.Value == setting_change && taikoMod.DrainRate.Value == setting_change &&
@ -410,7 +410,7 @@ namespace osu.Game.Tests.Visual.UserInterface
AddAssert("non-shared settings remain default", () => AddAssert("non-shared settings remain default", () =>
{ {
var taikoMod = getMod<TaikoModDifficultyAdjust>(); var taikoMod = getSelectedMod<TaikoModDifficultyAdjust>();
return taikoMod.ScrollSpeed.IsDefault; return taikoMod.ScrollSpeed.IsDefault;
}); });
@ -626,7 +626,7 @@ namespace osu.Game.Tests.Visual.UserInterface
AddAssert($"customisation toggle is {(active ? "" : "not ")}active", () => modSelectOverlay.CustomisationButton.AsNonNull().Active.Value == active); AddAssert($"customisation toggle is {(active ? "" : "not ")}active", () => modSelectOverlay.CustomisationButton.AsNonNull().Active.Value == active);
} }
private T getMod<T>() where T : Mod => (T)SelectedMods.Value.Single(); private T getSelectedMod<T>() where T : Mod => SelectedMods.Value.OfType<T>().Single();
private ModPanel getPanelForMod(Type modType) private ModPanel getPanelForMod(Type modType)
=> modSelectOverlay.ChildrenOfType<ModPanel>().Single(panel => panel.Mod.GetType() == modType); => modSelectOverlay.ChildrenOfType<ModPanel>().Single(panel => panel.Mod.GetType() == modType);