From 7e1e26de2a3b3bc8e249ba75b417e4d5955d7c42 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Tue, 26 May 2020 17:00:55 +0900
Subject: [PATCH] Allow HandleMovement by default
---
.../Edit/Compose/Components/SelectionHandler.cs | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs b/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs
index 9ecda9fdb8..7ab6340e07 100644
--- a/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs
+++ b/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs
@@ -74,9 +74,16 @@ namespace osu.Game.Screens.Edit.Compose.Components
/// <summary>
/// Handles the selected <see cref="DrawableHitObject"/>s being moved.
/// </summary>
+ /// <remarks>
+ /// Just returning true is enough to allow <see cref="HitObject.StartTime"/> updates to take place.
+ /// Custom implementation is only required if other attributes are to be considered, like changing columns.
+ /// </remarks>
/// <param name="moveEvent">The move event.</param>
- /// <returns>Whether any <see cref="DrawableHitObject"/>s were moved.</returns>
- public virtual bool HandleMovement(MoveSelectionEvent moveEvent) => false;
+ /// <returns>
+ /// Whether any <see cref="DrawableHitObject"/>s could be moved.
+ /// Returning true will also propagate StartTime changes provided by the closest <see cref="IPositionSnapProvider.SnapScreenSpacePositionToValidTime"/>.
+ /// </returns>
+ public virtual bool HandleMovement(MoveSelectionEvent moveEvent) => true;
public bool OnPressed(PlatformAction action)
{