h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 11:28:00 +08:00
Code Issues Releases Wiki Activity

Merge pull request #26484 from bdach/only-validate-playback-rate-when-submitting

Browse Source 
Only validate playback rate when in submission context
This commit is contained in:
Dean Herbert 2024-01-13 12:10:55 +09:00 committed by GitHub
commit 98fe9f32d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game.Tests/Visual/Gameplay/TestScenePlayerScoreSubmission.cs
View File

@ -21,7 +21,6 @@ using osu.Game.Rulesets.Osu.Judgements;
using osu.Game.Rulesets.Scoring; using osu.Game.Rulesets.Scoring;
using osu.Game.Rulesets.Taiko; using osu.Game.Rulesets.Taiko;
using osu.Game.Scoring; using osu.Game.Scoring;
using osu.Game.Screens.Play;
using osu.Game.Screens.Ranking; using osu.Game.Screens.Ranking;
using osu.Game.Tests.Beatmaps; using osu.Game.Tests.Beatmaps;
@ -360,11 +359,6 @@ namespace osu.Game.Tests.Visual.Gameplay
AllowImportCompletion = new SemaphoreSlim(1); AllowImportCompletion = new SemaphoreSlim(1);
} }
protected override GameplayClockContainer CreateGameplayClockContainer(WorkingBeatmap beatmap, double gameplayStart) => new MasterGameplayClockContainer(beatmap, gameplayStart)
{
ShouldValidatePlaybackRate = false,
};
protected override async Task ImportScore(Score score) protected override async Task ImportScore(Score score)
{ {
ScoreImportStarted = true; ScoreImportStarted = true;

2
osu.Game/Screens/Play/MasterGameplayClockContainer.cs
View File

@ -44,7 +44,7 @@ namespace osu.Game.Screens.Play
/// Whether the audio playback rate should be validated. /// Whether the audio playback rate should be validated.
/// Mostly disabled for tests. /// Mostly disabled for tests.
/// </summary> /// </summary>
internal bool ShouldValidatePlaybackRate { get; init; } = true; internal bool ShouldValidatePlaybackRate { get; init; }
/// <summary> /// <summary>
/// Whether the audio playback is within acceptable ranges. /// Whether the audio playback is within acceptable ranges.

5
osu.Game/Screens/Play/SubmittingPlayer.cs
View File

@ -61,6 +61,11 @@ namespace osu.Game.Screens.Play
AddInternal(new PlayerTouchInputDetector()); AddInternal(new PlayerTouchInputDetector());
} }
protected override GameplayClockContainer CreateGameplayClockContainer(WorkingBeatmap beatmap, double gameplayStart) => new MasterGameplayClockContainer(beatmap, gameplayStart)
{
ShouldValidatePlaybackRate = true,
};
protected override void LoadAsyncComplete() protected override void LoadAsyncComplete()
{ {
base.LoadAsyncComplete(); base.LoadAsyncComplete();