h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 01:52:55 +08:00
Code Issues Releases Wiki Activity

Fix star counter animating weird and delayed

Browse Source
This commit is contained in:
Joseph Madamba 2023-09-04 21:34:53 -07:00
parent 9accd0ded2
commit 98d027d207
No known key found for this signature in database
GPG Key ID: 8B746C7BDDF0BD76
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/Screens/Select/BeatmapInfoWedgeV2.cs
View File

@ -187,11 +187,16 @@ namespace osu.Game.Screens.Select
Info.DisplayedStars.BindValueChanged(s => Info.DisplayedStars.BindValueChanged(s =>
{ {
starCounter.Current = (float)s.NewValue;
starCounter.Colour = s.NewValue >= 6.5 ? colours.Orange1 : Colour4.Black.Opacity(0.75f); starCounter.Colour = s.NewValue >= 6.5 ? colours.Orange1 : Colour4.Black.Opacity(0.75f);
difficultyColourBar.FadeColour(colours.ForStarDifficulty(s.NewValue)); difficultyColourBar.FadeColour(colours.ForStarDifficulty(s.NewValue));
}, true); }, true);
Info.ActualStars.BindValueChanged(s =>
{
// use actual stars as star counter has its own animation
starCounter.Current = (float)s.NewValue;
});
}); });
}); });
@ -215,6 +220,7 @@ namespace osu.Game.Screens.Select
private readonly WorkingBeatmap working; private readonly WorkingBeatmap working;
public IBindable<double> DisplayedStars => starRatingDisplay.DisplayedStars; public IBindable<double> DisplayedStars => starRatingDisplay.DisplayedStars;
public Bindable<double> ActualStars = new Bindable<double>();
[Resolved] [Resolved]
private IBindable<IReadOnlyList<Mod>> mods { get; set; } = null!; private IBindable<IReadOnlyList<Mod>> mods { get; set; } = null!;
@ -312,6 +318,7 @@ namespace osu.Game.Screens.Select
starDifficulty.BindValueChanged(s => starDifficulty.BindValueChanged(s =>
{ {
starRatingDisplay.Current.Value = s.NewValue ?? default; starRatingDisplay.Current.Value = s.NewValue ?? default;
ActualStars.Value = s.NewValue?.Stars ?? 0;
// Don't roll the counter on initial display (but still allow it to roll on applying mods etc.) // Don't roll the counter on initial display (but still allow it to roll on applying mods etc.)
if (!starRatingDisplay.IsPresent) if (!starRatingDisplay.IsPresent)