From cab0b3451f5f3b6e6cf374dc25b1d7309eb07cd1 Mon Sep 17 00:00:00 2001 From: dnfd1 <117837311+dnfd1@users.noreply.github.com> Date: Wed, 8 Oct 2025 21:26:45 -0700 Subject: [PATCH 1/4] Override OD setting to set extended limits for mania EZ and HR --- osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs b/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs index 0817f8f9fc..9514f72fe0 100644 --- a/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs +++ b/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs @@ -7,5 +7,14 @@ namespace osu.Game.Rulesets.Mania.Mods { public class ManiaModDifficultyAdjust : ModDifficultyAdjust { + public override DifficultyBindable OverallDifficulty { get; } = new DifficultyBindable + { + Precision = 0.1f, + MinValue = 0, + MaxValue = 10, + ExtendedMaxValue = 13.61f, + ExtendedMinValue = -14.93f, + ReadCurrentFromDifficulty = diff => diff.OverallDifficulty, + }; } } From 348713d83d86fb22219910d3782c46e1a7956e6a Mon Sep 17 00:00:00 2001 From: dnfd1 <117837311+dnfd1@users.noreply.github.com> Date: Wed, 8 Oct 2025 21:27:49 -0700 Subject: [PATCH 2/4] Allow OD to be overrided --- osu.Game/Rulesets/Mods/ModDifficultyAdjust.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game/Rulesets/Mods/ModDifficultyAdjust.cs b/osu.Game/Rulesets/Mods/ModDifficultyAdjust.cs index da5f5df200..c6eaa75e9e 100644 --- a/osu.Game/Rulesets/Mods/ModDifficultyAdjust.cs +++ b/osu.Game/Rulesets/Mods/ModDifficultyAdjust.cs @@ -48,7 +48,7 @@ namespace osu.Game.Rulesets.Mods }; [SettingSource("Accuracy", "Override a beatmap's set OD.", LAST_SETTING_ORDER, SettingControlType = typeof(DifficultyAdjustSettingsControl))] - public DifficultyBindable OverallDifficulty { get; } = new DifficultyBindable + public virtual DifficultyBindable OverallDifficulty { get; } = new DifficultyBindable { Precision = 0.1f, MinValue = 0, From faad1753a4f9e051fffb4c41d8e4f5f54f7c12e2 Mon Sep 17 00:00:00 2001 From: dnfd1 <117837311+dnfd1@users.noreply.github.com> Date: Thu, 9 Oct 2025 05:13:17 -0700 Subject: [PATCH 3/4] Round OD limits to -15 and 15 --- osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs b/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs index 9514f72fe0..c1c25ad62e 100644 --- a/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs +++ b/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs @@ -12,8 +12,8 @@ namespace osu.Game.Rulesets.Mania.Mods Precision = 0.1f, MinValue = 0, MaxValue = 10, - ExtendedMaxValue = 13.61f, - ExtendedMinValue = -14.93f, + ExtendedMaxValue = 15, + ExtendedMinValue = -15, ReadCurrentFromDifficulty = diff => diff.OverallDifficulty, }; } From 0d68e5eeeb305b46e73410a97a6ccd7d6f4014d9 Mon Sep 17 00:00:00 2001 From: dnfd1 <117837311+dnfd1@users.noreply.github.com> Date: Thu, 9 Oct 2025 05:21:08 -0700 Subject: [PATCH 4/4] add inline comment to explain larger limits --- osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs b/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs index c1c25ad62e..ce70fdf73a 100644 --- a/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs +++ b/osu.Game.Rulesets.Mania/Mods/ManiaModDifficultyAdjust.cs @@ -12,6 +12,7 @@ namespace osu.Game.Rulesets.Mania.Mods Precision = 0.1f, MinValue = 0, MaxValue = 10, + // Use larger extended limits for mania to include OD values that occur with EZ or HR enabled ExtendedMaxValue = 15, ExtendedMinValue = -15, ReadCurrentFromDifficulty = diff => diff.OverallDifficulty,