From 94b34a5474cf625b274f3b6f84477417b62ee179 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Sat, 4 Sep 2021 23:19:05 +0900
Subject: [PATCH] Add test coverage of invalid cases too

---
 .../Settings/TestSceneTabletSettings.cs       | 24 ++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/osu.Game.Tests/Visual/Settings/TestSceneTabletSettings.cs b/osu.Game.Tests/Visual/Settings/TestSceneTabletSettings.cs
index a854bec1a9..d5bcbc5fd9 100644
--- a/osu.Game.Tests/Visual/Settings/TestSceneTabletSettings.cs
+++ b/osu.Game.Tests/Visual/Settings/TestSceneTabletSettings.cs
@@ -54,7 +54,7 @@ namespace osu.Game.Tests.Visual.Settings
         }
 
         [Test]
-        public void TestValidAfterRotation()
+        public void TestRotationValidity()
         {
             AddAssert("area valid", () => settings.AreaSelection.IsWithinBounds);
 
@@ -75,6 +75,22 @@ namespace osu.Game.Tests.Visual.Settings
 
             AddStep("rotate 0", () => tabletHandler.Rotation.Value = 0);
             ensureValid();
+
+            AddStep("rotate 0", () => tabletHandler.Rotation.Value = 45);
+            ensureInvalid();
+
+            AddStep("rotate 0", () => tabletHandler.Rotation.Value = 0);
+            ensureValid();
+        }
+
+        [Test]
+        public void TestOffsetValidity()
+        {
+            ensureValid();
+            AddStep("move right", () => tabletHandler.AreaOffset.Value = Vector2.Zero);
+            ensureInvalid();
+            AddStep("move back", () => tabletHandler.AreaOffset.Value = tabletHandler.AreaSize.Value / 2);
+            ensureValid();
         }
 
         private void ensureValid()
@@ -83,6 +99,12 @@ namespace osu.Game.Tests.Visual.Settings
             AddAssert("area valid", () => settings.AreaSelection.IsWithinBounds);
         }
 
+        private void ensureInvalid()
+        {
+            AddUntilStep("wait for transforms", () => settings.AreaSelection.ChildrenOfType<Container>().All(c => !c.Transforms.Any()));
+            AddAssert("area invalid", () => !settings.AreaSelection.IsWithinBounds);
+        }
+
         public class TestTabletHandler : ITabletHandler
         {
             public Bindable<Vector2> AreaOffset { get; } = new Bindable<Vector2>();