h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 19:53:23 +08:00
Code Issues Releases Wiki Activity

Completely remove click sound debounce

Browse Source
This commit is contained in:
Min 2019-11-28 16:03:59 +11:00 committed by GitHub
parent 786fb9ede3
commit 92ab8026a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Graphics/UserInterface/HoverClickSounds.cs
View File

@ -1,4 +1,4 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text. // See the LICENCE file in the repository root for full licence text.
using System.Linq; using System.Linq;
@ -7,7 +7,6 @@ using osu.Framework.Audio;
using osu.Framework.Audio.Sample; using osu.Framework.Audio.Sample;
using osu.Framework.Extensions; using osu.Framework.Extensions;
using osu.Framework.Input.Events; using osu.Framework.Input.Events;
using osu.Framework.Threading;
using osuTK.Input; using osuTK.Input;
namespace osu.Game.Graphics.UserInterface namespace osu.Game.Graphics.UserInterface
@ -21,11 +20,6 @@ namespace osu.Game.Graphics.UserInterface
private SampleChannel sampleClick; private SampleChannel sampleClick;
private readonly MouseButton[] buttons; private readonly MouseButton[] buttons;
/// <summary>
/// Length of debounce for click sound playback, in milliseconds. Default is 0ms.
/// </summary>
public double ClickDebounceTime { get; set; }
/// <summary> /// <summary>
/// a container which plays sounds on hover and click for any specified <see cref="MouseButton"/>s. /// a container which plays sounds on hover and click for any specified <see cref="MouseButton"/>s.
/// </summary> /// </summary>
@ -40,19 +34,10 @@ namespace osu.Game.Graphics.UserInterface
this.buttons = buttons ?? new[] { MouseButton.Left }; this.buttons = buttons ?? new[] { MouseButton.Left };
} }
private ScheduledDelegate playDelegate;
protected override bool OnClick(ClickEvent e) protected override bool OnClick(ClickEvent e)
{ {
playDelegate?.Cancel();
if (buttons.Contains(e.Button) && Contains(e.ScreenSpaceMousePosition)) if (buttons.Contains(e.Button) && Contains(e.ScreenSpaceMousePosition))
{
if (ClickDebounceTime <= 0)
sampleClick?.Play(); sampleClick?.Play();
else
playDelegate = Scheduler.AddDelayed(() => sampleClick?.Play(), ClickDebounceTime);
}
return base.OnClick(e); return base.OnClick(e);
} }