h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-14 15:07:52 +08:00
Code Issues Releases Wiki Activity

Updated comments

Browse Source
This commit is contained in:
Aurelian 2024-05-31 01:30:26 +02:00
parent 542809a748
commit 9111da81d2
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/Rulesets/Objects/SliderPath.cs
View File

@ -332,16 +332,15 @@ namespace osu.Game.Rulesets.Objects
CircularArcProperties circularArcProperties = new CircularArcProperties(subControlPoints); CircularArcProperties circularArcProperties = new CircularArcProperties(subControlPoints);
//if false, we'll end up breaking anyways when calculating subPath // `PathApproximator` will already internally revert to B-spline if the arc isn't valid.
if (!circularArcProperties.IsValid) if (!circularArcProperties.IsValid)
break; break;
//Coppied from PathApproximator.CircularArcToPiecewiseLinear // taken from https://github.com/ppy/osu-framework/blob/1201e641699a1d50d2f6f9295192dad6263d5820/osu.Framework/Utils/PathApproximator.cs#L181-L186
int subPoints = (2f * circularArcProperties.Radius <= 0.1f) ? 2 : Math.Max(2, (int)Math.Ceiling(circularArcProperties.ThetaRange / (2.0 * Math.Acos(1f - (0.1f / circularArcProperties.Radius))))); int subPoints = (2f * circularArcProperties.Radius <= 0.1f) ? 2 : Math.Max(2, (int)Math.Ceiling(circularArcProperties.ThetaRange / (2.0 * Math.Acos(1f - (0.1f / circularArcProperties.Radius)))));
//theoretically can be int.MaxValue, but lets set this to a lower value anyways // 1000 subpoints requires an arc length of at least ~120 thousand to occur
//1000 requires an arc length of over 20 thousand to surpass this limit, which should be safe. // See here for calculations https://www.desmos.com/calculator/umj6jvmcz7
//See here for calculations https://www.desmos.com/calculator/210bwswkbb
if (subPoints >= 1000) if (subPoints >= 1000)
break; break;