h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-27 14:43:07 +08:00
Code Issues Releases Wiki Activity

Add safety against double disposal

Browse Source
This commit is contained in:
Dean Herbert 2021-06-28 16:12:21 +09:00
parent 842f033522
commit 90f0bc87f5
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
osu.Game/Database/RealmContextFactory.cs
View File

@ -126,22 +126,28 @@ namespace osu.Game.Database
protected override void Dispose(bool isDisposing) protected override void Dispose(bool isDisposing)
{ {
base.Dispose(isDisposing); if (!IsDisposed)
{
// intentionally block all operations indefinitely. this ensures that nothing can start consuming a new context after disposal. // intentionally block all operations indefinitely. this ensures that nothing can start consuming a new context after disposal.
BlockAllOperations(); BlockAllOperations();
blockingLock?.Dispose(); blockingLock?.Dispose();
} }
base.Dispose(isDisposing);
}
public IDisposable BlockAllOperations() public IDisposable BlockAllOperations()
{ {
if (IsDisposed)
throw new InvalidOperationException(@"Attempted to block operations after already disposed.");
blockingLock.Wait(); blockingLock.Wait();
flushContexts(); flushContexts();
return new InvokeOnDisposal<RealmContextFactory>(this, endBlockingSection); return new InvokeOnDisposal<RealmContextFactory>(this, endBlockingSection);
}
private static void endBlockingSection(RealmContextFactory factory) => factory.blockingLock.Release(); static void endBlockingSection(RealmContextFactory factory) => factory.blockingLock.Release();
}
private void flushContexts() private void flushContexts()
{ {