1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 04:02:57 +08:00

Remove dysfunctional slider colouring

This commit is contained in:
mk56-spn 2023-02-15 10:04:50 +01:00
parent 297963b461
commit 8fc35b159f

View File

@ -18,7 +18,6 @@ using osu.Game.Rulesets.Mods;
using osu.Game.Rulesets.Objects.Drawables; using osu.Game.Rulesets.Objects.Drawables;
using osu.Game.Rulesets.Osu.Objects; using osu.Game.Rulesets.Osu.Objects;
using osu.Game.Rulesets.Osu.Objects.Drawables; using osu.Game.Rulesets.Osu.Objects.Drawables;
using osu.Game.Rulesets.Osu.Skinning.Default;
using osu.Game.Rulesets.Scoring; using osu.Game.Rulesets.Scoring;
using osu.Game.Rulesets.UI; using osu.Game.Rulesets.UI;
using osu.Game.Scoring; using osu.Game.Scoring;
@ -77,12 +76,6 @@ namespace osu.Game.Rulesets.Osu.Mods
public void ApplyToDrawableHitObject(DrawableHitObject drawableObject) public void ApplyToDrawableHitObject(DrawableHitObject drawableObject)
{ {
if (drawableObject is DrawableSlider slider)
{
applySliderState(slider);
slider.Body.OnSkinChanged += () => applySliderState(slider);
}
drawableObject.OnNewResult += (drawable, _) => drawableObject.OnNewResult += (drawable, _) =>
{ {
if (drawable is not DrawableOsuHitObject drawableOsuHitObject) return; if (drawable is not DrawableOsuHitObject drawableOsuHitObject) return;
@ -122,10 +115,6 @@ namespace osu.Game.Rulesets.Osu.Mods
}; };
} }
// Makes the slider border coloured on all skins (for aesthetics)
private void applySliderState(DrawableSlider slider) =>
((PlaySliderBody)slider.Body.Drawable).BorderColour = slider.AccentColour.Value;
#region Pooled Bubble drawable #region Pooled Bubble drawable
private partial class BubbleDrawable : PoolableDrawable private partial class BubbleDrawable : PoolableDrawable