1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 04:13:00 +08:00

Merge pull request #912 from johnneijzen/master

Clean up
This commit is contained in:
Dean Herbert 2017-06-08 14:26:03 +09:00 committed by GitHub
commit 8f909354bf
10 changed files with 14 additions and 28 deletions

View File

@ -448,7 +448,6 @@ namespace osu.Game.Rulesets.Mania.Beatmaps.Patterns.Legacy
return curveData.RepeatSamples[index]; return curveData.RepeatSamples[index];
} }
/// <summary> /// <summary>
/// Constructs and adds a note to a pattern. /// Constructs and adds a note to a pattern.
/// </summary> /// </summary>
@ -480,7 +479,6 @@ namespace osu.Game.Rulesets.Mania.Beatmaps.Patterns.Legacy
Tail = { Samples = sampleInfoListAt(endTime) } Tail = { Samples = sampleInfoListAt(endTime) }
}; };
newObject = holdNote; newObject = holdNote;
} }

View File

@ -13,7 +13,6 @@ namespace osu.Game.Configuration
protected override void InitialiseDefaults() protected override void InitialiseDefaults()
{ {
// UI/selection defaults // UI/selection defaults
Set(OsuSetting.Ruleset, 0, 0, int.MaxValue); Set(OsuSetting.Ruleset, 0, 0, int.MaxValue);
Set(OsuSetting.BeatmapDetailTab, BeatmapDetailTab.Details); Set(OsuSetting.BeatmapDetailTab, BeatmapDetailTab.Details);
@ -25,7 +24,6 @@ namespace osu.Game.Configuration
Set(OsuSetting.ChatDisplayHeight, ChatOverlay.DEFAULT_HEIGHT, 0.2, 1); Set(OsuSetting.ChatDisplayHeight, ChatOverlay.DEFAULT_HEIGHT, 0.2, 1);
// Online settings // Online settings
Set(OsuSetting.Username, string.Empty); Set(OsuSetting.Username, string.Empty);
Set(OsuSetting.Token, string.Empty); Set(OsuSetting.Token, string.Empty);
@ -40,14 +38,12 @@ namespace osu.Game.Configuration
}; };
// Audio // Audio
Set(OsuSetting.MenuVoice, true); Set(OsuSetting.MenuVoice, true);
Set(OsuSetting.MenuMusic, true); Set(OsuSetting.MenuMusic, true);
Set(OsuSetting.AudioOffset, 0, -500.0, 500.0); Set(OsuSetting.AudioOffset, 0, -500.0, 500.0);
// Input // Input
Set(OsuSetting.MenuCursorSize, 1.0, 0.5f, 2); Set(OsuSetting.MenuCursorSize, 1.0, 0.5f, 2);
Set(OsuSetting.GameplayCursorSize, 1.0, 0.5f, 2); Set(OsuSetting.GameplayCursorSize, 1.0, 0.5f, 2);
Set(OsuSetting.AutoCursorSize, false); Set(OsuSetting.AutoCursorSize, false);
@ -56,7 +52,6 @@ namespace osu.Game.Configuration
Set(OsuSetting.MouseDisableWheel, false); Set(OsuSetting.MouseDisableWheel, false);
// Graphics // Graphics
Set(OsuSetting.ShowFpsDisplay, false); Set(OsuSetting.ShowFpsDisplay, false);
Set(OsuSetting.MenuParallax, true); Set(OsuSetting.MenuParallax, true);
@ -65,7 +60,6 @@ namespace osu.Game.Configuration
Set(OsuSetting.SnakingOutSliders, true); Set(OsuSetting.SnakingOutSliders, true);
// Gameplay // Gameplay
Set(OsuSetting.DimLevel, 0.3, 0, 1); Set(OsuSetting.DimLevel, 0.3, 0, 1);
Set(OsuSetting.ShowInterface, true); Set(OsuSetting.ShowInterface, true);
@ -75,7 +69,6 @@ namespace osu.Game.Configuration
Set(OsuSetting.PlaybackSpeed, 1.0, 0.5f, 2); Set(OsuSetting.PlaybackSpeed, 1.0, 0.5f, 2);
// Update // Update
Set(OsuSetting.ReleaseStream, ReleaseStream.Lazer); Set(OsuSetting.ReleaseStream, ReleaseStream.Lazer);
} }

View File

@ -150,7 +150,7 @@ namespace osu.Game
RelativeSizeAxes = Axes.Both, RelativeSizeAxes = Axes.Both,
}, },
volume = new VolumeControl(), volume = new VolumeControl(),
overlayContent = new Container{ RelativeSizeAxes = Axes.Both }, overlayContent = new Container { RelativeSizeAxes = Axes.Both },
new OnScreenDisplay(), new OnScreenDisplay(),
new GlobalHotkeys //exists because UserInputManager is at a level below us. new GlobalHotkeys //exists because UserInputManager is at a level below us.
{ {

View File

@ -367,7 +367,6 @@ namespace osu.Game.Overlays
} }
else else
{ {
careChannels.Add(channel); careChannels.Add(channel);
channelTabs.AddItem(channel); channelTabs.AddItem(channel);
} }

View File

@ -66,7 +66,7 @@ namespace osu.Game.Screens.Menu
Scale = new Vector2(0, 1), Scale = new Vector2(0, 1),
Size = boxSize, Size = boxSize,
Shear = new Vector2(ButtonSystem.WEDGE_WIDTH / boxSize.Y, 0), Shear = new Vector2(ButtonSystem.WEDGE_WIDTH / boxSize.Y, 0),
Children = new [] Children = new[]
{ {
new Box new Box
{ {
@ -282,10 +282,10 @@ namespace osu.Game.Screens.Menu
public ButtonState State public ButtonState State
{ {
get { return state; } get{ return state; }
set set
{ {
if (state == value) if (state == value)
return; return;

View File

@ -51,10 +51,7 @@ namespace osu.Game.Screens.Menu
public bool Triangles public bool Triangles
{ {
set set { colourAndTriangles.Alpha = value ? 1 : 0; }
{
colourAndTriangles.Alpha = value ? 1 : 0;
}
} }
protected override bool InternalContains(Vector2 screenSpacePos) => logoContainer.Contains(screenSpacePos); protected override bool InternalContains(Vector2 screenSpacePos) => logoContainer.Contains(screenSpacePos);
@ -62,10 +59,7 @@ namespace osu.Game.Screens.Menu
public bool Ripple public bool Ripple
{ {
get { return rippleContainer.Alpha > 0; } get { return rippleContainer.Alpha > 0; }
set set { rippleContainer.Alpha = value ? 1 : 0; }
{
rippleContainer.Alpha = value ? 1 : 0;
}
} }
public bool Interactive = true; public bool Interactive = true;

View File

@ -278,7 +278,6 @@ namespace osu.Game.Screens.Play
{ {
if (!pauseContainer.IsPaused) if (!pauseContainer.IsPaused)
decoupledClock.Start(); decoupledClock.Start();
}); });
pauseContainer.Alpha = 0; pauseContainer.Alpha = 0;

View File

@ -244,7 +244,7 @@ namespace osu.Game.Screens.Select
private BeatmapGroup createGroup(BeatmapSetInfo beatmapSet) private BeatmapGroup createGroup(BeatmapSetInfo beatmapSet)
{ {
foreach(var b in beatmapSet.Beatmaps) foreach (var b in beatmapSet.Beatmaps)
{ {
if (b.Metadata == null) if (b.Metadata == null)
b.Metadata = beatmapSet.Metadata; b.Metadata = beatmapSet.Metadata;

View File

@ -47,6 +47,7 @@ namespace osu.Game.Screens.Select
public BeatmapInfo Beatmap public BeatmapInfo Beatmap
{ {
get { return beatmap; } get { return beatmap; }
set set
{ {
if (beatmap == value) return; if (beatmap == value) return;
@ -165,7 +166,7 @@ namespace osu.Game.Screens.Select
Direction = FillDirection.Vertical, Direction = FillDirection.Vertical,
LayoutDuration = 200, LayoutDuration = 200,
LayoutEasing = EasingTypes.OutQuint, LayoutEasing = EasingTypes.OutQuint,
Children = new [] Children = new[]
{ {
description = new MetadataSegment("Description"), description = new MetadataSegment("Description"),
source = new MetadataSegment("Source"), source = new MetadataSegment("Source"),
@ -199,9 +200,9 @@ namespace osu.Game.Screens.Select
RelativeSizeAxes = Axes.X, RelativeSizeAxes = Axes.X,
AutoSizeAxes = Axes.Y, AutoSizeAxes = Axes.Y,
Direction = FillDirection.Vertical, Direction = FillDirection.Vertical,
Spacing = new Vector2(0,5), Spacing = new Vector2(0, 5),
Padding = new MarginPadding(10), Padding = new MarginPadding(10),
Children = new [] Children = new[]
{ {
circleSize = new DifficultyRow("Circle Size", 7), circleSize = new DifficultyRow("Circle Size", 7),
drainRate = new DifficultyRow("HP Drain"), drainRate = new DifficultyRow("HP Drain"),
@ -479,7 +480,7 @@ namespace osu.Game.Screens.Select
RelativeSizeAxes = Axes.X, RelativeSizeAxes = Axes.X,
AutoSizeAxes = Axes.Y, AutoSizeAxes = Axes.Y,
Direction = FillDirection.Full, Direction = FillDirection.Full,
Spacing = new Vector2(5,0), Spacing = new Vector2(5, 0),
Margin = new MarginPadding { Top = header.TextSize } Margin = new MarginPadding { Top = header.TextSize }
} }
}; };

View File

@ -83,6 +83,7 @@ namespace osu.Game.Screens.Tournament
private ScrollState scrollState private ScrollState scrollState
{ {
get { return _scrollState; } get { return _scrollState; }
set set
{ {
if (_scrollState == value) if (_scrollState == value)
@ -329,6 +330,7 @@ namespace osu.Game.Screens.Tournament
public bool Selected public bool Selected
{ {
get { return selected; } get { return selected; }
set set
{ {
selected = value; selected = value;