mirror of
https://github.com/ppy/osu.git
synced 2024-12-15 01:02:55 +08:00
Merge pull request #26169 from bdach/universal-offset-from-session-plays
Implement automatic suggestion of global audio offset based on last plays
This commit is contained in:
commit
8e3fe090f3
@ -12,6 +12,7 @@ using osu.Game.Rulesets.Mods;
|
|||||||
using osu.Game.Rulesets.Osu.Mods;
|
using osu.Game.Rulesets.Osu.Mods;
|
||||||
using osu.Game.Scoring;
|
using osu.Game.Scoring;
|
||||||
using osu.Game.Screens.Play.PlayerSettings;
|
using osu.Game.Screens.Play.PlayerSettings;
|
||||||
|
using osu.Game.Tests.Resources;
|
||||||
using osu.Game.Tests.Visual.Ranking;
|
using osu.Game.Tests.Visual.Ranking;
|
||||||
|
|
||||||
namespace osu.Game.Tests.Visual.Gameplay
|
namespace osu.Game.Tests.Visual.Gameplay
|
||||||
@ -44,7 +45,23 @@ namespace osu.Game.Tests.Visual.Gameplay
|
|||||||
{
|
{
|
||||||
offsetControl.ReferenceScore.Value = new ScoreInfo
|
offsetControl.ReferenceScore.Value = new ScoreInfo
|
||||||
{
|
{
|
||||||
HitEvents = TestSceneHitEventTimingDistributionGraph.CreateDistributedHitEvents(0, 2)
|
HitEvents = TestSceneHitEventTimingDistributionGraph.CreateDistributedHitEvents(0, 2),
|
||||||
|
BeatmapInfo = Beatmap.Value.BeatmapInfo,
|
||||||
|
};
|
||||||
|
});
|
||||||
|
|
||||||
|
AddAssert("No calibration button", () => !offsetControl.ChildrenOfType<SettingsButton>().Any());
|
||||||
|
}
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void TestScoreFromDifferentBeatmap()
|
||||||
|
{
|
||||||
|
AddStep("Set short reference score", () =>
|
||||||
|
{
|
||||||
|
offsetControl.ReferenceScore.Value = new ScoreInfo
|
||||||
|
{
|
||||||
|
HitEvents = TestSceneHitEventTimingDistributionGraph.CreateDistributedHitEvents(10),
|
||||||
|
BeatmapInfo = TestResources.CreateTestBeatmapSetInfo().Beatmaps.First(),
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
@ -59,7 +76,8 @@ namespace osu.Game.Tests.Visual.Gameplay
|
|||||||
offsetControl.ReferenceScore.Value = new ScoreInfo
|
offsetControl.ReferenceScore.Value = new ScoreInfo
|
||||||
{
|
{
|
||||||
HitEvents = TestSceneHitEventTimingDistributionGraph.CreateDistributedHitEvents(10),
|
HitEvents = TestSceneHitEventTimingDistributionGraph.CreateDistributedHitEvents(10),
|
||||||
Mods = new Mod[] { new OsuModRelax() }
|
Mods = new Mod[] { new OsuModRelax() },
|
||||||
|
BeatmapInfo = Beatmap.Value.BeatmapInfo,
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
@ -77,7 +95,8 @@ namespace osu.Game.Tests.Visual.Gameplay
|
|||||||
{
|
{
|
||||||
offsetControl.ReferenceScore.Value = new ScoreInfo
|
offsetControl.ReferenceScore.Value = new ScoreInfo
|
||||||
{
|
{
|
||||||
HitEvents = TestSceneHitEventTimingDistributionGraph.CreateDistributedHitEvents(average_error)
|
HitEvents = TestSceneHitEventTimingDistributionGraph.CreateDistributedHitEvents(average_error),
|
||||||
|
BeatmapInfo = Beatmap.Value.BeatmapInfo,
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
@ -105,7 +124,8 @@ namespace osu.Game.Tests.Visual.Gameplay
|
|||||||
{
|
{
|
||||||
offsetControl.ReferenceScore.Value = new ScoreInfo
|
offsetControl.ReferenceScore.Value = new ScoreInfo
|
||||||
{
|
{
|
||||||
HitEvents = TestSceneHitEventTimingDistributionGraph.CreateDistributedHitEvents(average_error)
|
HitEvents = TestSceneHitEventTimingDistributionGraph.CreateDistributedHitEvents(average_error),
|
||||||
|
BeatmapInfo = Beatmap.Value.BeatmapInfo,
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
|
@ -0,0 +1,63 @@
|
|||||||
|
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
||||||
|
// See the LICENCE file in the repository root for full licence text.
|
||||||
|
|
||||||
|
using NUnit.Framework;
|
||||||
|
using osu.Framework.Allocation;
|
||||||
|
using osu.Framework.Bindables;
|
||||||
|
using osu.Framework.Graphics;
|
||||||
|
using osu.Framework.Graphics.Containers;
|
||||||
|
using osu.Framework.Utils;
|
||||||
|
using osu.Game.Configuration;
|
||||||
|
using osu.Game.Overlays.Settings.Sections.Audio;
|
||||||
|
using osu.Game.Scoring;
|
||||||
|
using osu.Game.Tests.Visual.Ranking;
|
||||||
|
|
||||||
|
namespace osu.Game.Tests.Visual.Settings
|
||||||
|
{
|
||||||
|
public partial class TestSceneAudioOffsetAdjustControl : OsuTestScene
|
||||||
|
{
|
||||||
|
[Resolved]
|
||||||
|
private SessionStatics statics { get; set; } = null!;
|
||||||
|
|
||||||
|
[Cached]
|
||||||
|
private SessionAverageHitErrorTracker tracker = new SessionAverageHitErrorTracker();
|
||||||
|
|
||||||
|
private Container content = null!;
|
||||||
|
protected override Container Content => content;
|
||||||
|
|
||||||
|
[BackgroundDependencyLoader]
|
||||||
|
private void load()
|
||||||
|
{
|
||||||
|
base.Content.AddRange(new Drawable[]
|
||||||
|
{
|
||||||
|
tracker,
|
||||||
|
content = new Container
|
||||||
|
{
|
||||||
|
Anchor = Anchor.Centre,
|
||||||
|
Origin = Anchor.Centre,
|
||||||
|
Width = 400,
|
||||||
|
AutoSizeAxes = Axes.Y
|
||||||
|
}
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void TestBehaviour()
|
||||||
|
{
|
||||||
|
AddStep("create control", () => Child = new AudioOffsetAdjustControl
|
||||||
|
{
|
||||||
|
Current = new BindableDouble
|
||||||
|
{
|
||||||
|
MinValue = -500,
|
||||||
|
MaxValue = 500
|
||||||
|
}
|
||||||
|
});
|
||||||
|
AddStep("set new score", () => statics.SetValue(Static.LastLocalUserScore, new ScoreInfo
|
||||||
|
{
|
||||||
|
HitEvents = TestSceneHitEventTimingDistributionGraph.CreateDistributedHitEvents(RNG.NextDouble(-100, 100)),
|
||||||
|
BeatmapInfo = Beatmap.Value.BeatmapInfo,
|
||||||
|
}));
|
||||||
|
AddStep("clear history", () => tracker.ClearHistory());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
54
osu.Game/Configuration/SessionAverageHitErrorTracker.cs
Normal file
54
osu.Game/Configuration/SessionAverageHitErrorTracker.cs
Normal file
@ -0,0 +1,54 @@
|
|||||||
|
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
||||||
|
// See the LICENCE file in the repository root for full licence text.
|
||||||
|
|
||||||
|
using System.Linq;
|
||||||
|
using osu.Framework.Allocation;
|
||||||
|
using osu.Framework.Bindables;
|
||||||
|
using osu.Framework.Graphics;
|
||||||
|
using osu.Game.Rulesets.Mods;
|
||||||
|
using osu.Game.Rulesets.Scoring;
|
||||||
|
using osu.Game.Scoring;
|
||||||
|
|
||||||
|
namespace osu.Game.Configuration
|
||||||
|
{
|
||||||
|
/// <summary>
|
||||||
|
/// Tracks the local user's average hit error during the ongoing play session.
|
||||||
|
/// </summary>
|
||||||
|
[Cached]
|
||||||
|
public partial class SessionAverageHitErrorTracker : Component
|
||||||
|
{
|
||||||
|
public IBindableList<double> AverageHitErrorHistory => averageHitErrorHistory;
|
||||||
|
private readonly BindableList<double> averageHitErrorHistory = new BindableList<double>();
|
||||||
|
|
||||||
|
private readonly Bindable<ScoreInfo?> latestScore = new Bindable<ScoreInfo?>();
|
||||||
|
|
||||||
|
[BackgroundDependencyLoader]
|
||||||
|
private void load(SessionStatics statics)
|
||||||
|
{
|
||||||
|
statics.BindWith(Static.LastLocalUserScore, latestScore);
|
||||||
|
latestScore.BindValueChanged(score => calculateAverageHitError(score.NewValue), true);
|
||||||
|
}
|
||||||
|
|
||||||
|
private void calculateAverageHitError(ScoreInfo? newScore)
|
||||||
|
{
|
||||||
|
if (newScore == null)
|
||||||
|
return;
|
||||||
|
|
||||||
|
if (newScore.Mods.Any(m => !m.UserPlayable || m is IHasNoTimedInputs))
|
||||||
|
return;
|
||||||
|
|
||||||
|
if (newScore.HitEvents.Count < 10)
|
||||||
|
return;
|
||||||
|
|
||||||
|
if (newScore.HitEvents.CalculateAverageHitError() is not double averageError)
|
||||||
|
return;
|
||||||
|
|
||||||
|
// keep a sane maximum number of entries.
|
||||||
|
if (averageHitErrorHistory.Count >= 50)
|
||||||
|
averageHitErrorHistory.RemoveAt(0);
|
||||||
|
averageHitErrorHistory.Add(averageError);
|
||||||
|
}
|
||||||
|
|
||||||
|
public void ClearHistory() => averageHitErrorHistory.Clear();
|
||||||
|
}
|
||||||
|
}
|
@ -9,6 +9,7 @@ using osu.Game.Input;
|
|||||||
using osu.Game.Online.API.Requests.Responses;
|
using osu.Game.Online.API.Requests.Responses;
|
||||||
using osu.Game.Overlays;
|
using osu.Game.Overlays;
|
||||||
using osu.Game.Overlays.Mods;
|
using osu.Game.Overlays.Mods;
|
||||||
|
using osu.Game.Scoring;
|
||||||
|
|
||||||
namespace osu.Game.Configuration
|
namespace osu.Game.Configuration
|
||||||
{
|
{
|
||||||
@ -27,6 +28,7 @@ namespace osu.Game.Configuration
|
|||||||
SetDefault(Static.LastModSelectPanelSamplePlaybackTime, (double?)null);
|
SetDefault(Static.LastModSelectPanelSamplePlaybackTime, (double?)null);
|
||||||
SetDefault<APISeasonalBackgrounds>(Static.SeasonalBackgrounds, null);
|
SetDefault<APISeasonalBackgrounds>(Static.SeasonalBackgrounds, null);
|
||||||
SetDefault(Static.TouchInputActive, RuntimeInfo.IsMobile);
|
SetDefault(Static.TouchInputActive, RuntimeInfo.IsMobile);
|
||||||
|
SetDefault<ScoreInfo>(Static.LastLocalUserScore, null);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
@ -73,5 +75,10 @@ namespace osu.Game.Configuration
|
|||||||
/// Used in touchscreen detection scenarios (<see cref="TouchInputInterceptor"/>).
|
/// Used in touchscreen detection scenarios (<see cref="TouchInputInterceptor"/>).
|
||||||
/// </summary>
|
/// </summary>
|
||||||
TouchInputActive,
|
TouchInputActive,
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Stores the local user's last score (can be completed or aborted).
|
||||||
|
/// </summary>
|
||||||
|
LastLocalUserScore,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -200,6 +200,8 @@ namespace osu.Game
|
|||||||
|
|
||||||
private RulesetConfigCache rulesetConfigCache;
|
private RulesetConfigCache rulesetConfigCache;
|
||||||
|
|
||||||
|
private SessionAverageHitErrorTracker hitErrorTracker;
|
||||||
|
|
||||||
protected SpectatorClient SpectatorClient { get; private set; }
|
protected SpectatorClient SpectatorClient { get; private set; }
|
||||||
|
|
||||||
protected MultiplayerClient MultiplayerClient { get; private set; }
|
protected MultiplayerClient MultiplayerClient { get; private set; }
|
||||||
@ -349,6 +351,7 @@ namespace osu.Game
|
|||||||
dependencies.CacheAs(powerStatus);
|
dependencies.CacheAs(powerStatus);
|
||||||
|
|
||||||
dependencies.Cache(SessionStatics = new SessionStatics());
|
dependencies.Cache(SessionStatics = new SessionStatics());
|
||||||
|
dependencies.Cache(hitErrorTracker = new SessionAverageHitErrorTracker());
|
||||||
dependencies.Cache(Colours = new OsuColour());
|
dependencies.Cache(Colours = new OsuColour());
|
||||||
|
|
||||||
RegisterImportHandler(BeatmapManager);
|
RegisterImportHandler(BeatmapManager);
|
||||||
@ -408,6 +411,7 @@ namespace osu.Game
|
|||||||
});
|
});
|
||||||
|
|
||||||
base.Content.Add(new TouchInputInterceptor());
|
base.Content.Add(new TouchInputInterceptor());
|
||||||
|
base.Content.Add(hitErrorTracker);
|
||||||
|
|
||||||
KeyBindingStore = new RealmKeyBindingStore(realm, keyCombinationProvider);
|
KeyBindingStore = new RealmKeyBindingStore(realm, keyCombinationProvider);
|
||||||
KeyBindingStore.Register(globalBindings, RulesetStore.AvailableRulesets);
|
KeyBindingStore.Register(globalBindings, RulesetStore.AvailableRulesets);
|
||||||
|
@ -0,0 +1,160 @@
|
|||||||
|
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
||||||
|
// See the LICENCE file in the repository root for full licence text.
|
||||||
|
|
||||||
|
using System;
|
||||||
|
using System.Collections.Specialized;
|
||||||
|
using System.Diagnostics;
|
||||||
|
using System.Linq;
|
||||||
|
using osu.Framework.Allocation;
|
||||||
|
using osu.Framework.Bindables;
|
||||||
|
using osu.Framework.Extensions.IEnumerableExtensions;
|
||||||
|
using osu.Framework.Graphics;
|
||||||
|
using osu.Framework.Graphics.Containers;
|
||||||
|
using osu.Framework.Graphics.Shapes;
|
||||||
|
using osu.Framework.Graphics.UserInterface;
|
||||||
|
using osu.Game.Configuration;
|
||||||
|
using osu.Game.Graphics;
|
||||||
|
using osu.Game.Graphics.Containers;
|
||||||
|
using osu.Game.Graphics.UserInterface;
|
||||||
|
using osu.Game.Graphics.UserInterfaceV2;
|
||||||
|
using osu.Game.Localisation;
|
||||||
|
using osuTK;
|
||||||
|
|
||||||
|
namespace osu.Game.Overlays.Settings.Sections.Audio
|
||||||
|
{
|
||||||
|
public partial class AudioOffsetAdjustControl : SettingsItem<double>
|
||||||
|
{
|
||||||
|
[BackgroundDependencyLoader]
|
||||||
|
private void load()
|
||||||
|
{
|
||||||
|
LabelText = AudioSettingsStrings.AudioOffset;
|
||||||
|
}
|
||||||
|
|
||||||
|
protected override Drawable CreateControl() => new AudioOffsetPreview();
|
||||||
|
|
||||||
|
private partial class AudioOffsetPreview : CompositeDrawable, IHasCurrentValue<double>
|
||||||
|
{
|
||||||
|
public Bindable<double> Current
|
||||||
|
{
|
||||||
|
get => current.Current;
|
||||||
|
set => current.Current = value;
|
||||||
|
}
|
||||||
|
|
||||||
|
private readonly BindableNumberWithCurrent<double> current = new BindableNumberWithCurrent<double>();
|
||||||
|
|
||||||
|
private readonly IBindableList<double> averageHitErrorHistory = new BindableList<double>();
|
||||||
|
|
||||||
|
private readonly Bindable<double?> suggestedOffset = new Bindable<double?>();
|
||||||
|
|
||||||
|
private Container<Box> notchContainer = null!;
|
||||||
|
private TextFlowContainer hintText = null!;
|
||||||
|
private RoundedButton applySuggestion = null!;
|
||||||
|
|
||||||
|
[BackgroundDependencyLoader]
|
||||||
|
private void load(SessionAverageHitErrorTracker hitErrorTracker)
|
||||||
|
{
|
||||||
|
averageHitErrorHistory.BindTo(hitErrorTracker.AverageHitErrorHistory);
|
||||||
|
|
||||||
|
RelativeSizeAxes = Axes.X;
|
||||||
|
AutoSizeAxes = Axes.Y;
|
||||||
|
InternalChild = new FillFlowContainer
|
||||||
|
{
|
||||||
|
RelativeSizeAxes = Axes.X,
|
||||||
|
AutoSizeAxes = Axes.Y,
|
||||||
|
Spacing = new Vector2(10),
|
||||||
|
Direction = FillDirection.Vertical,
|
||||||
|
Children = new Drawable[]
|
||||||
|
{
|
||||||
|
new TimeSlider
|
||||||
|
{
|
||||||
|
RelativeSizeAxes = Axes.X,
|
||||||
|
Current = { BindTarget = Current },
|
||||||
|
KeyboardStep = 1,
|
||||||
|
},
|
||||||
|
notchContainer = new Container<Box>
|
||||||
|
{
|
||||||
|
RelativeSizeAxes = Axes.X,
|
||||||
|
Height = 10,
|
||||||
|
Padding = new MarginPadding { Horizontal = Nub.DEFAULT_EXPANDED_SIZE / 2 },
|
||||||
|
Anchor = Anchor.TopCentre,
|
||||||
|
Origin = Anchor.TopCentre,
|
||||||
|
},
|
||||||
|
hintText = new OsuTextFlowContainer(t => t.Font = OsuFont.Default.With(size: 16))
|
||||||
|
{
|
||||||
|
RelativeSizeAxes = Axes.X,
|
||||||
|
AutoSizeAxes = Axes.Y,
|
||||||
|
},
|
||||||
|
applySuggestion = new RoundedButton
|
||||||
|
{
|
||||||
|
RelativeSizeAxes = Axes.X,
|
||||||
|
Text = "Apply suggested offset",
|
||||||
|
Action = () =>
|
||||||
|
{
|
||||||
|
if (suggestedOffset.Value.HasValue)
|
||||||
|
current.Value = suggestedOffset.Value.Value;
|
||||||
|
hitErrorTracker.ClearHistory();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
protected override void LoadComplete()
|
||||||
|
{
|
||||||
|
base.LoadComplete();
|
||||||
|
|
||||||
|
averageHitErrorHistory.BindCollectionChanged(updateDisplay, true);
|
||||||
|
suggestedOffset.BindValueChanged(_ => updateHintText(), true);
|
||||||
|
}
|
||||||
|
|
||||||
|
private void updateDisplay(object? _, NotifyCollectionChangedEventArgs e)
|
||||||
|
{
|
||||||
|
switch (e.Action)
|
||||||
|
{
|
||||||
|
case NotifyCollectionChangedAction.Add:
|
||||||
|
foreach (double average in e.NewItems!)
|
||||||
|
{
|
||||||
|
notchContainer.ForEach(n => n.Alpha *= 0.95f);
|
||||||
|
notchContainer.Add(new Box
|
||||||
|
{
|
||||||
|
RelativeSizeAxes = Axes.Y,
|
||||||
|
Width = 2,
|
||||||
|
RelativePositionAxes = Axes.X,
|
||||||
|
Anchor = Anchor.Centre,
|
||||||
|
Origin = Anchor.Centre,
|
||||||
|
X = getXPositionForAverage(average)
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
break;
|
||||||
|
|
||||||
|
case NotifyCollectionChangedAction.Remove:
|
||||||
|
foreach (double average in e.OldItems!)
|
||||||
|
{
|
||||||
|
var notch = notchContainer.FirstOrDefault(n => n.X == getXPositionForAverage(average));
|
||||||
|
Debug.Assert(notch != null);
|
||||||
|
notchContainer.Remove(notch, true);
|
||||||
|
}
|
||||||
|
|
||||||
|
break;
|
||||||
|
|
||||||
|
case NotifyCollectionChangedAction.Reset:
|
||||||
|
notchContainer.Clear();
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
|
suggestedOffset.Value = averageHitErrorHistory.Any() ? -averageHitErrorHistory.Average() : null;
|
||||||
|
}
|
||||||
|
|
||||||
|
private float getXPositionForAverage(double average) => (float)(Math.Clamp(-average, current.MinValue, current.MaxValue) / (2 * current.MaxValue));
|
||||||
|
|
||||||
|
private void updateHintText()
|
||||||
|
{
|
||||||
|
hintText.Text = suggestedOffset.Value == null
|
||||||
|
? @"Play a few beatmaps to receive a suggested offset!"
|
||||||
|
: $@"Based on the last {averageHitErrorHistory.Count} play(s), the suggested offset is {suggestedOffset.Value:N0} ms.";
|
||||||
|
applySuggestion.Enabled.Value = suggestedOffset.Value != null;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
@ -7,7 +7,6 @@ using osu.Framework.Allocation;
|
|||||||
using osu.Framework.Graphics;
|
using osu.Framework.Graphics;
|
||||||
using osu.Framework.Localisation;
|
using osu.Framework.Localisation;
|
||||||
using osu.Game.Configuration;
|
using osu.Game.Configuration;
|
||||||
using osu.Game.Graphics.UserInterface;
|
|
||||||
using osu.Game.Localisation;
|
using osu.Game.Localisation;
|
||||||
|
|
||||||
namespace osu.Game.Overlays.Settings.Sections.Audio
|
namespace osu.Game.Overlays.Settings.Sections.Audio
|
||||||
@ -16,23 +15,17 @@ namespace osu.Game.Overlays.Settings.Sections.Audio
|
|||||||
{
|
{
|
||||||
protected override LocalisableString Header => AudioSettingsStrings.OffsetHeader;
|
protected override LocalisableString Header => AudioSettingsStrings.OffsetHeader;
|
||||||
|
|
||||||
public override IEnumerable<LocalisableString> FilterTerms => base.FilterTerms.Concat(new LocalisableString[] { "universal", "uo", "timing", "delay", "latency" });
|
public override IEnumerable<LocalisableString> FilterTerms => base.FilterTerms.Concat(new LocalisableString[] { "universal", "uo", "timing", "delay", "latency", "wizard" });
|
||||||
|
|
||||||
[BackgroundDependencyLoader]
|
[BackgroundDependencyLoader]
|
||||||
private void load(OsuConfigManager config)
|
private void load(OsuConfigManager config)
|
||||||
{
|
{
|
||||||
Children = new Drawable[]
|
Children = new Drawable[]
|
||||||
{
|
{
|
||||||
new SettingsSlider<double, TimeSlider>
|
new AudioOffsetAdjustControl
|
||||||
{
|
{
|
||||||
LabelText = AudioSettingsStrings.AudioOffset,
|
|
||||||
Current = config.GetBindable<double>(OsuSetting.AudioOffset),
|
Current = config.GetBindable<double>(OsuSetting.AudioOffset),
|
||||||
KeyboardStep = 1f
|
|
||||||
},
|
},
|
||||||
new SettingsButton
|
|
||||||
{
|
|
||||||
Text = AudioSettingsStrings.OffsetWizard
|
|
||||||
}
|
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -3,19 +3,21 @@
|
|||||||
|
|
||||||
#nullable disable
|
#nullable disable
|
||||||
|
|
||||||
|
using System.Collections.Generic;
|
||||||
|
using System.Linq;
|
||||||
using osu.Framework.Allocation;
|
using osu.Framework.Allocation;
|
||||||
|
using osu.Framework.Bindables;
|
||||||
using osu.Framework.Graphics;
|
using osu.Framework.Graphics;
|
||||||
using osu.Framework.Graphics.Containers;
|
using osu.Framework.Graphics.Containers;
|
||||||
|
using osu.Framework.Graphics.Sprites;
|
||||||
|
using osu.Framework.Localisation;
|
||||||
|
using osu.Framework.Testing;
|
||||||
|
using osu.Game.Graphics;
|
||||||
|
using osu.Game.Localisation;
|
||||||
using osu.Game.Overlays.Settings;
|
using osu.Game.Overlays.Settings;
|
||||||
using osu.Game.Overlays.Settings.Sections;
|
using osu.Game.Overlays.Settings.Sections;
|
||||||
using osu.Game.Overlays.Settings.Sections.Input;
|
using osu.Game.Overlays.Settings.Sections.Input;
|
||||||
using osuTK.Graphics;
|
using osuTK.Graphics;
|
||||||
using System.Collections.Generic;
|
|
||||||
using osu.Framework.Bindables;
|
|
||||||
using osu.Framework.Graphics.Sprites;
|
|
||||||
using osu.Framework.Localisation;
|
|
||||||
using osu.Game.Graphics;
|
|
||||||
using osu.Game.Localisation;
|
|
||||||
|
|
||||||
namespace osu.Game.Overlays
|
namespace osu.Game.Overlays
|
||||||
{
|
{
|
||||||
@ -55,6 +57,21 @@ namespace osu.Game.Overlays
|
|||||||
|
|
||||||
public override bool AcceptsFocus => lastOpenedSubPanel == null || lastOpenedSubPanel.State.Value == Visibility.Hidden;
|
public override bool AcceptsFocus => lastOpenedSubPanel == null || lastOpenedSubPanel.State.Value == Visibility.Hidden;
|
||||||
|
|
||||||
|
public void ShowAtControl<T>()
|
||||||
|
where T : Drawable
|
||||||
|
{
|
||||||
|
Show();
|
||||||
|
|
||||||
|
// wait for load of sections
|
||||||
|
if (!SectionsContainer.Any())
|
||||||
|
{
|
||||||
|
Scheduler.Add(ShowAtControl<T>);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
SectionsContainer.ScrollTo(SectionsContainer.ChildrenOfType<T>().Single());
|
||||||
|
}
|
||||||
|
|
||||||
private T createSubPanel<T>(T subPanel)
|
private T createSubPanel<T>(T subPanel)
|
||||||
where T : SettingsSubPanel
|
where T : SettingsSubPanel
|
||||||
{
|
{
|
||||||
|
@ -207,6 +207,7 @@ namespace osu.Game.Scoring
|
|||||||
|
|
||||||
clone.Statistics = new Dictionary<HitResult, int>(clone.Statistics);
|
clone.Statistics = new Dictionary<HitResult, int>(clone.Statistics);
|
||||||
clone.MaximumStatistics = new Dictionary<HitResult, int>(clone.MaximumStatistics);
|
clone.MaximumStatistics = new Dictionary<HitResult, int>(clone.MaximumStatistics);
|
||||||
|
clone.HitEvents = new List<HitEvent>(clone.HitEvents);
|
||||||
|
|
||||||
// Ensure we have fresh mods to avoid any references (ie. after gameplay).
|
// Ensure we have fresh mods to avoid any references (ie. after gameplay).
|
||||||
clone.clearAllMods();
|
clone.clearAllMods();
|
||||||
|
@ -263,10 +263,6 @@ namespace osu.Game.Screens.Play
|
|||||||
|
|
||||||
Debug.Assert(CurrentPlayer != null);
|
Debug.Assert(CurrentPlayer != null);
|
||||||
|
|
||||||
var lastScore = CurrentPlayer.Score;
|
|
||||||
|
|
||||||
AudioSettings.ReferenceScore.Value = lastScore?.ScoreInfo;
|
|
||||||
|
|
||||||
// prepare for a retry.
|
// prepare for a retry.
|
||||||
CurrentPlayer = null;
|
CurrentPlayer = null;
|
||||||
playerConsumed = false;
|
playerConsumed = false;
|
||||||
|
@ -14,7 +14,7 @@ namespace osu.Game.Screens.Play.PlayerSettings
|
|||||||
{
|
{
|
||||||
public partial class AudioSettings : PlayerSettingsGroup
|
public partial class AudioSettings : PlayerSettingsGroup
|
||||||
{
|
{
|
||||||
public Bindable<ScoreInfo> ReferenceScore { get; } = new Bindable<ScoreInfo>();
|
private Bindable<ScoreInfo> referenceScore { get; } = new Bindable<ScoreInfo>();
|
||||||
|
|
||||||
private readonly PlayerCheckbox beatmapHitsoundsToggle;
|
private readonly PlayerCheckbox beatmapHitsoundsToggle;
|
||||||
|
|
||||||
@ -26,15 +26,16 @@ namespace osu.Game.Screens.Play.PlayerSettings
|
|||||||
beatmapHitsoundsToggle = new PlayerCheckbox { LabelText = SkinSettingsStrings.BeatmapHitsounds },
|
beatmapHitsoundsToggle = new PlayerCheckbox { LabelText = SkinSettingsStrings.BeatmapHitsounds },
|
||||||
new BeatmapOffsetControl
|
new BeatmapOffsetControl
|
||||||
{
|
{
|
||||||
ReferenceScore = { BindTarget = ReferenceScore },
|
ReferenceScore = { BindTarget = referenceScore },
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
[BackgroundDependencyLoader]
|
[BackgroundDependencyLoader]
|
||||||
private void load(OsuConfigManager config)
|
private void load(OsuConfigManager config, SessionStatics statics)
|
||||||
{
|
{
|
||||||
beatmapHitsoundsToggle.Current = config.GetBindable<bool>(OsuSetting.BeatmapHitsounds);
|
beatmapHitsoundsToggle.Current = config.GetBindable<bool>(OsuSetting.BeatmapHitsounds);
|
||||||
|
statics.BindWith(Static.LastLocalUserScore, referenceScore);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -7,6 +7,7 @@ using System.Linq;
|
|||||||
using System.Threading.Tasks;
|
using System.Threading.Tasks;
|
||||||
using osu.Framework.Allocation;
|
using osu.Framework.Allocation;
|
||||||
using osu.Framework.Bindables;
|
using osu.Framework.Bindables;
|
||||||
|
using osu.Framework.Extensions.ObjectExtensions;
|
||||||
using osu.Framework.Graphics;
|
using osu.Framework.Graphics;
|
||||||
using osu.Framework.Graphics.Containers;
|
using osu.Framework.Graphics.Containers;
|
||||||
using osu.Framework.Input.Bindings;
|
using osu.Framework.Input.Bindings;
|
||||||
@ -20,7 +21,9 @@ using osu.Game.Graphics.Containers;
|
|||||||
using osu.Game.Graphics.Sprites;
|
using osu.Game.Graphics.Sprites;
|
||||||
using osu.Game.Input.Bindings;
|
using osu.Game.Input.Bindings;
|
||||||
using osu.Game.Localisation;
|
using osu.Game.Localisation;
|
||||||
|
using osu.Game.Overlays;
|
||||||
using osu.Game.Overlays.Settings;
|
using osu.Game.Overlays.Settings;
|
||||||
|
using osu.Game.Overlays.Settings.Sections.Audio;
|
||||||
using osu.Game.Rulesets.Mods;
|
using osu.Game.Rulesets.Mods;
|
||||||
using osu.Game.Rulesets.Scoring;
|
using osu.Game.Rulesets.Scoring;
|
||||||
using osu.Game.Scoring;
|
using osu.Game.Scoring;
|
||||||
@ -157,11 +160,11 @@ namespace osu.Game.Screens.Play.PlayerSettings
|
|||||||
// Apply to all difficulties in a beatmap set for now (they generally always share timing).
|
// Apply to all difficulties in a beatmap set for now (they generally always share timing).
|
||||||
foreach (var b in setInfo.Beatmaps)
|
foreach (var b in setInfo.Beatmaps)
|
||||||
{
|
{
|
||||||
BeatmapUserSettings settings = b.UserSettings;
|
BeatmapUserSettings userSettings = b.UserSettings;
|
||||||
double val = Current.Value;
|
double val = Current.Value;
|
||||||
|
|
||||||
if (settings.Offset != val)
|
if (userSettings.Offset != val)
|
||||||
settings.Offset = val;
|
userSettings.Offset = val;
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
@ -174,6 +177,9 @@ namespace osu.Game.Screens.Play.PlayerSettings
|
|||||||
if (score.NewValue == null)
|
if (score.NewValue == null)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
|
if (!score.NewValue.BeatmapInfo.AsNonNull().Equals(beatmap.Value.BeatmapInfo))
|
||||||
|
return;
|
||||||
|
|
||||||
if (score.NewValue.Mods.Any(m => !m.UserPlayable || m is IHasNoTimedInputs))
|
if (score.NewValue.Mods.Any(m => !m.UserPlayable || m is IHasNoTimedInputs))
|
||||||
return;
|
return;
|
||||||
|
|
||||||
@ -209,6 +215,8 @@ namespace osu.Game.Screens.Play.PlayerSettings
|
|||||||
lastPlayAverage = average;
|
lastPlayAverage = average;
|
||||||
lastPlayBeatmapOffset = Current.Value;
|
lastPlayBeatmapOffset = Current.Value;
|
||||||
|
|
||||||
|
LinkFlowContainer globalOffsetText;
|
||||||
|
|
||||||
referenceScoreContainer.AddRange(new Drawable[]
|
referenceScoreContainer.AddRange(new Drawable[]
|
||||||
{
|
{
|
||||||
lastPlayGraph = new HitEventTimingDistributionGraph(hitEvents)
|
lastPlayGraph = new HitEventTimingDistributionGraph(hitEvents)
|
||||||
@ -222,9 +230,24 @@ namespace osu.Game.Screens.Play.PlayerSettings
|
|||||||
Text = BeatmapOffsetControlStrings.CalibrateUsingLastPlay,
|
Text = BeatmapOffsetControlStrings.CalibrateUsingLastPlay,
|
||||||
Action = () => Current.Value = lastPlayBeatmapOffset - lastPlayAverage
|
Action = () => Current.Value = lastPlayBeatmapOffset - lastPlayAverage
|
||||||
},
|
},
|
||||||
|
globalOffsetText = new LinkFlowContainer
|
||||||
|
{
|
||||||
|
RelativeSizeAxes = Axes.X,
|
||||||
|
AutoSizeAxes = Axes.Y,
|
||||||
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
if (settings != null)
|
||||||
|
{
|
||||||
|
globalOffsetText.AddText("You can also ");
|
||||||
|
globalOffsetText.AddLink("adjust the global offset", () => settings.ShowAtControl<AudioOffsetAdjustControl>());
|
||||||
|
globalOffsetText.AddText(" based off this play.");
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Resolved]
|
||||||
|
private SettingsOverlay? settings { get; set; }
|
||||||
|
|
||||||
protected override void Dispose(bool isDisposing)
|
protected override void Dispose(bool isDisposing)
|
||||||
{
|
{
|
||||||
base.Dispose(isDisposing);
|
base.Dispose(isDisposing);
|
||||||
|
@ -11,6 +11,7 @@ using osu.Framework.Allocation;
|
|||||||
using osu.Framework.Logging;
|
using osu.Framework.Logging;
|
||||||
using osu.Framework.Screens;
|
using osu.Framework.Screens;
|
||||||
using osu.Game.Beatmaps;
|
using osu.Game.Beatmaps;
|
||||||
|
using osu.Game.Configuration;
|
||||||
using osu.Game.Database;
|
using osu.Game.Database;
|
||||||
using osu.Game.Online.API;
|
using osu.Game.Online.API;
|
||||||
using osu.Game.Online.Multiplayer;
|
using osu.Game.Online.Multiplayer;
|
||||||
@ -37,6 +38,9 @@ namespace osu.Game.Screens.Play
|
|||||||
[Resolved]
|
[Resolved]
|
||||||
private SpectatorClient spectatorClient { get; set; }
|
private SpectatorClient spectatorClient { get; set; }
|
||||||
|
|
||||||
|
[Resolved]
|
||||||
|
private SessionStatics statics { get; set; }
|
||||||
|
|
||||||
private TaskCompletionSource<bool> scoreSubmissionSource;
|
private TaskCompletionSource<bool> scoreSubmissionSource;
|
||||||
|
|
||||||
protected SubmittingPlayer(PlayerConfiguration configuration = null)
|
protected SubmittingPlayer(PlayerConfiguration configuration = null)
|
||||||
@ -176,6 +180,7 @@ namespace osu.Game.Screens.Play
|
|||||||
{
|
{
|
||||||
bool exiting = base.OnExiting(e);
|
bool exiting = base.OnExiting(e);
|
||||||
submitFromFailOrQuit();
|
submitFromFailOrQuit();
|
||||||
|
statics.SetValue(Static.LastLocalUserScore, Score?.ScoreInfo.DeepClone());
|
||||||
return exiting;
|
return exiting;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user