h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 11:27:24 +08:00
Code Issues Releases Wiki Activity

Fix song select potentially operating on Carousel before it is fully loaded

Browse Source 
Should fix test failures like
https://github.com/ppy/osu/actions/runs/3939620830/jobs/6739690253.
This commit is contained in:
Dean Herbert 2023-01-18 01:56:12 +09:00
parent 3f2077a527
commit 8e1002b744
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Screens/Select/SongSelect.cs
View File

@ -860,9 +860,13 @@ namespace osu.Game.Screens.Select
Logger.Log($"decoupled ruleset transferred (\"{decoupledRuleset.Value}\" -> \"{Ruleset.Value}\")"); Logger.Log($"decoupled ruleset transferred (\"{decoupledRuleset.Value}\" -> \"{Ruleset.Value}\")");
rulesetNoDebounce = decoupledRuleset.Value = Ruleset.Value; rulesetNoDebounce = decoupledRuleset.Value = Ruleset.Value;
// if we have a pending filter operation, we want to run it now. if (Carousel.IsLoaded)
// it could change selection (ie. if the ruleset has been changed). {
Carousel.FlushPendingFilterOperations(); // if we have a pending filter operation, we want to run it now.
// it could change selection (ie. if the ruleset has been changed).
Carousel.FlushPendingFilterOperations();
}
return true; return true;
} }