From 8cdd9c9ddcec526dcf4866f2c0b0ce1b98dbffd4 Mon Sep 17 00:00:00 2001
From: Sheepposu <apc2005osu@gmail.com>
Date: Fri, 23 Feb 2024 23:46:50 -0500
Subject: [PATCH] skinning changes

improve default design
---
 .../Skinning/Default/DefaultHitMarker.cs                  | 8 +++-----
 osu.Game.Rulesets.Osu/Skinning/OsuSkinColour.cs           | 1 -
 osu.Game.Rulesets.Osu/UI/OsuAnalysisContainer.cs          | 6 +-----
 3 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/osu.Game.Rulesets.Osu/Skinning/Default/DefaultHitMarker.cs b/osu.Game.Rulesets.Osu/Skinning/Default/DefaultHitMarker.cs
index 7dabb5182f..dc890d4d63 100644
--- a/osu.Game.Rulesets.Osu/Skinning/Default/DefaultHitMarker.cs
+++ b/osu.Game.Rulesets.Osu/Skinning/Default/DefaultHitMarker.cs
@@ -23,7 +23,6 @@ namespace osu.Game.Rulesets.Osu.Skinning.Default
                         Anchor = Anchor.Centre,
                         Origin = Anchor.Centre,
                         Size = new Vector2(3, length),
-                        Rotation = 45,
                         Colour = Colour4.Black.Opacity(0.5F)
                     },
                     new Box
@@ -31,7 +30,7 @@ namespace osu.Game.Rulesets.Osu.Skinning.Default
                         Anchor = Anchor.Centre,
                         Origin = Anchor.Centre,
                         Size = new Vector2(3, length),
-                        Rotation = 135,
+                        Rotation = 90,
                         Colour = Colour4.Black.Opacity(0.5F)
                     }
                 };
@@ -44,7 +43,6 @@ namespace osu.Game.Rulesets.Osu.Skinning.Default
                     Anchor = Anchor.Centre,
                     Origin = Anchor.Centre,
                     Size = new Vector2(1, length),
-                    Rotation = 45,
                     Colour = colour
                 },
                 new Box
@@ -52,7 +50,7 @@ namespace osu.Game.Rulesets.Osu.Skinning.Default
                     Anchor = Anchor.Centre,
                     Origin = Anchor.Centre,
                     Size = new Vector2(1, length),
-                    Rotation = 135,
+                    Rotation = 90,
                     Colour = colour
                 }
             });
@@ -69,7 +67,7 @@ namespace osu.Game.Rulesets.Osu.Skinning.Default
                     return (Colour4.LightGreen, 20, true);
 
                 default:
-                    return (Colour4.Gray.Opacity(0.3F), 8, false);
+                    return (Colour4.Gray.Opacity(0.5F), 8, false);
             }
         }
     }
diff --git a/osu.Game.Rulesets.Osu/Skinning/OsuSkinColour.cs b/osu.Game.Rulesets.Osu/Skinning/OsuSkinColour.cs
index 5c864fb6c2..24f9217a5f 100644
--- a/osu.Game.Rulesets.Osu/Skinning/OsuSkinColour.cs
+++ b/osu.Game.Rulesets.Osu/Skinning/OsuSkinColour.cs
@@ -10,6 +10,5 @@ namespace osu.Game.Rulesets.Osu.Skinning
         SliderBall,
         SpinnerBackground,
         StarBreakAdditive,
-        ReplayAimLine,
     }
 }
diff --git a/osu.Game.Rulesets.Osu/UI/OsuAnalysisContainer.cs b/osu.Game.Rulesets.Osu/UI/OsuAnalysisContainer.cs
index a637eddd05..68686f835d 100644
--- a/osu.Game.Rulesets.Osu/UI/OsuAnalysisContainer.cs
+++ b/osu.Game.Rulesets.Osu/UI/OsuAnalysisContainer.cs
@@ -12,7 +12,6 @@ using osu.Framework.Graphics.Pooling;
 using osu.Game.Replays;
 using osu.Game.Rulesets.Objects.Pooling;
 using osu.Game.Rulesets.Osu.Replays;
-using osu.Game.Rulesets.Osu.Skinning;
 using osu.Game.Rulesets.Osu.Skinning.Default;
 using osu.Game.Rulesets.UI;
 using osu.Game.Skinning;
@@ -47,11 +46,8 @@ namespace osu.Game.Rulesets.Osu.UI
         }
 
         [BackgroundDependencyLoader]
-        private void load(ISkinSource skin)
+        private void load()
         {
-            var aimLineColor = skin.GetConfig<OsuSkinColour, Color4>(OsuSkinColour.ReplayAimLine)?.Value ?? Color4.White;
-            aimLineColor.A = 127;
-
             hitMarkersContainer.Hide();
             aimMarkersContainer.Hide();
             aimLinesContainer.Hide();