From 8bf85d737c75a71ba9e388842770cfc987f2bed7 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Mon, 12 Apr 2021 15:52:29 +0900
Subject: [PATCH] Change Metadata into a get property

---
 osu.Game.Rulesets.Osu/Edit/Checks/CheckOffscreenObjects.cs | 2 +-
 osu.Game/Rulesets/Edit/Checks/CheckBackground.cs           | 2 +-
 osu.Game/Rulesets/Edit/Checks/Components/Check.cs          | 2 +-
 osu.Game/Screens/Edit/Verify/IssueTable.cs                 | 2 +-
 osu.Game/Screens/Edit/Verify/VerifyScreen.cs               | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/osu.Game.Rulesets.Osu/Edit/Checks/CheckOffscreenObjects.cs b/osu.Game.Rulesets.Osu/Edit/Checks/CheckOffscreenObjects.cs
index b2a00da12a..252f65ab5a 100644
--- a/osu.Game.Rulesets.Osu/Edit/Checks/CheckOffscreenObjects.cs
+++ b/osu.Game.Rulesets.Osu/Edit/Checks/CheckOffscreenObjects.cs
@@ -22,7 +22,7 @@ namespace osu.Game.Rulesets.Osu.Edit.Checks
         // (higher = more performant, but higher false-negative chance).
         private const int path_step_size = 5;
 
-        public override CheckMetadata Metadata() => new CheckMetadata
+        public override CheckMetadata Metadata { get; } = new CheckMetadata
         (
             category: CheckCategory.Compose,
             description: "Offscreen hitobjects."
diff --git a/osu.Game/Rulesets/Edit/Checks/CheckBackground.cs b/osu.Game/Rulesets/Edit/Checks/CheckBackground.cs
index 89b2e8293c..22f98b6fd7 100644
--- a/osu.Game/Rulesets/Edit/Checks/CheckBackground.cs
+++ b/osu.Game/Rulesets/Edit/Checks/CheckBackground.cs
@@ -10,7 +10,7 @@ namespace osu.Game.Rulesets.Edit.Checks
 {
     public class CheckBackground : Check
     {
-        public override CheckMetadata Metadata() => new CheckMetadata
+        public override CheckMetadata Metadata { get; } = new CheckMetadata
         (
             category: CheckCategory.Resources,
             description: "Missing background."
diff --git a/osu.Game/Rulesets/Edit/Checks/Components/Check.cs b/osu.Game/Rulesets/Edit/Checks/Components/Check.cs
index 550d2ea0a2..7c039d1572 100644
--- a/osu.Game/Rulesets/Edit/Checks/Components/Check.cs
+++ b/osu.Game/Rulesets/Edit/Checks/Components/Check.cs
@@ -11,7 +11,7 @@ namespace osu.Game.Rulesets.Edit.Checks.Components
         /// <summary>
         /// The metadata for this check.
         /// </summary>
-        public abstract CheckMetadata Metadata();
+        public abstract CheckMetadata Metadata { get; }
 
         /// <summary>
         /// All possible templates for issues that this check may return.
diff --git a/osu.Game/Screens/Edit/Verify/IssueTable.cs b/osu.Game/Screens/Edit/Verify/IssueTable.cs
index 1f275ca537..84dbabf300 100644
--- a/osu.Game/Screens/Edit/Verify/IssueTable.cs
+++ b/osu.Game/Screens/Edit/Verify/IssueTable.cs
@@ -112,7 +112,7 @@ namespace osu.Game.Screens.Edit.Verify
             },
             new OsuSpriteText
             {
-                Text = issue.Template.Origin.Metadata().Category.ToString(),
+                Text = issue.Template.Origin.Metadata.Category.ToString(),
                 Font = OsuFont.GetFont(size: text_size, weight: FontWeight.Bold),
                 Margin = new MarginPadding(10)
             }
diff --git a/osu.Game/Screens/Edit/Verify/VerifyScreen.cs b/osu.Game/Screens/Edit/Verify/VerifyScreen.cs
index 7a520826f5..0c4aa04ff3 100644
--- a/osu.Game/Screens/Edit/Verify/VerifyScreen.cs
+++ b/osu.Game/Screens/Edit/Verify/VerifyScreen.cs
@@ -130,7 +130,7 @@ namespace osu.Game.Screens.Edit.Verify
             {
                 table.Issues = beatmapVerifier.Run(Beatmap)
                                               .OrderByDescending(issue => issue.Template.Type)
-                                              .ThenByDescending(issue => issue.Template.Origin.Metadata().Category);
+                                              .ThenByDescending(issue => issue.Template.Origin.Metadata.Category);
             }
         }
     }