h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-14 17:52:56 +08:00
Code Issues Releases Wiki Activity

More TestCaseManiaHitObjects fixes.

Browse Source
This commit is contained in:
smoogipooo 2017-09-11 04:34:30 +09:00
parent 3b5e847a31
commit 8bb8999820
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Desktop.Tests/Visual/TestCaseManiaHitObjects.cs
View File

@ -43,7 +43,6 @@ namespace osu.Desktop.Tests.Visual
{
new DrawableNote(new Note(), ManiaAction.Key1)
{
RelativePositionAxes = Axes.Y,
Y = 5000,
LifetimeStart = double.MinValue,
LifetimeEnd = double.MaxValue,
@ -51,7 +50,6 @@ namespace osu.Desktop.Tests.Visual
},
new DrawableNote(new Note(), ManiaAction.Key1)
{
RelativePositionAxes = Axes.Y,
Y = 6000,
LifetimeStart = double.MinValue,
LifetimeEnd = double.MaxValue,
@ -79,9 +77,8 @@ namespace osu.Desktop.Tests.Visual
{
new DrawableHoldNote(new HoldNote(), ManiaAction.Key1)
{
RelativePositionAxes = Axes.Y,
Y = 5000,
Height = 3000,
Height = 1000,
LifetimeStart = double.MinValue,
LifetimeEnd = double.MaxValue,
AccentColour = Color4.Red

8
osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
View File

@ -207,6 +207,10 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
RelativePositionAxes = Axes.None;
Y = 0;
// Life time managed by the parent DrawableHoldNote
LifetimeStart = double.MinValue;
LifetimeEnd = double.MaxValue;
HasOwnGlow = false;
}
@ -246,6 +250,10 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
RelativePositionAxes = Axes.None;
Y = 0;
// Life time managed by the parent DrawableHoldNote
LifetimeStart = double.MinValue;
LifetimeEnd = double.MaxValue;
HasOwnGlow = false;
}

2
osu.Game.Rulesets.Mania/Objects/Drawables/DrawableManiaHitObject.cs
View File

@ -1,6 +1,7 @@
// Copyright (c) 2007-2017 ppy Pty Ltd <contact@ppy.sh>.
// Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
using osu.Framework.Graphics;
using OpenTK.Graphics;
using osu.Game.Rulesets.Mania.Judgements;
using osu.Game.Rulesets.Objects.Drawables;
@ -20,6 +21,7 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
protected DrawableManiaHitObject(TObject hitObject, ManiaAction? action = null)
: base(hitObject)
{
RelativePositionAxes = Axes.Y;
HitObject = hitObject;
if (action != null)