h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 21:43:22 +08:00
Code Issues Releases Wiki Activity

Fix chat overlay tests

Browse Source 
Not entirely sure why they were failing previously, but the most likely
explanation is that by freak accident some mock requests would
previously execute immediately rather than be scheduled on the API
thread, which would change execution ordering and ensure that
`ChannelManager.CurrentChannel` would become the joined channel, rather
than remaining at the channel listing.
This commit is contained in:
Bartłomiej Dach 2024-08-30 14:57:15 +02:00
parent 8ffd4aa82c
commit 8b04455c29
No known key found for this signature in database
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game.Tests/Visual/Online/TestSceneChatOverlay.cs
View File

@ -446,7 +446,7 @@ namespace osu.Game.Tests.Visual.Online
{ {
AddStep("Show overlay with channel 1", () => AddStep("Show overlay with channel 1", () =>
{ {
channelManager.JoinChannel(testChannel1); channelManager.CurrentChannel.Value = channelManager.JoinChannel(testChannel1);
chatOverlay.Show(); chatOverlay.Show();
}); });
waitForChannel1Visible(); waitForChannel1Visible();
@ -462,7 +462,7 @@ namespace osu.Game.Tests.Visual.Online
{ {
AddStep("Show overlay with channel 1", () => AddStep("Show overlay with channel 1", () =>
{ {
channelManager.JoinChannel(testChannel1); channelManager.CurrentChannel.Value = channelManager.JoinChannel(testChannel1);
chatOverlay.Show(); chatOverlay.Show();
}); });
waitForChannel1Visible(); waitForChannel1Visible();