h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-21 23:59:16 +08:00
Code Issues Releases Wiki Activity

Add inline comments for iOS locals

Browse Source
This commit is contained in:
Dean Herbert 2024-09-26 16:48:42 +09:00
parent 2fe229d620
commit 89e8baf1d3
No known key found for this signature in database
5 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
osu.Game/Beatmaps/BeatmapImporter.cs
View File

@ -198,6 +198,7 @@ namespace osu.Game.Beatmaps
if (beatmapSet.OnlineID > 0) if (beatmapSet.OnlineID > 0)
{ {
// Required local for iOS. Will cause runtime crash if inlined.
int onlineId = beatmapSet.OnlineID; int onlineId = beatmapSet.OnlineID;
// OnlineID should really be unique, but to avoid catastrophic failure let's iterate just to be sure. // OnlineID should really be unique, but to avoid catastrophic failure let's iterate just to be sure.

1
osu.Game/Online/BeatmapDownloadTracker.cs
View File

@ -40,6 +40,7 @@ namespace osu.Game.Online
// Used to interact with manager classes that don't support interface types. Will eventually be replaced. // Used to interact with manager classes that don't support interface types. Will eventually be replaced.
var beatmapSetInfo = new BeatmapSetInfo { OnlineID = TrackedItem.OnlineID }; var beatmapSetInfo = new BeatmapSetInfo { OnlineID = TrackedItem.OnlineID };
// Required local for iOS. Will cause runtime crash if inlined.
int onlineId = TrackedItem.OnlineID; int onlineId = TrackedItem.OnlineID;
realmSubscription = realm.RegisterForNotifications(r => r.All<BeatmapSetInfo>().Where(s => s.OnlineID == onlineId && !s.DeletePending), (items, _) => realmSubscription = realm.RegisterForNotifications(r => r.All<BeatmapSetInfo>().Where(s => s.OnlineID == onlineId && !s.DeletePending), (items, _) =>

1
osu.Game/Online/ScoreDownloadTracker.cs
View File

@ -46,6 +46,7 @@ namespace osu.Game.Online
Downloader.DownloadBegan += downloadBegan; Downloader.DownloadBegan += downloadBegan;
Downloader.DownloadFailed += downloadFailed; Downloader.DownloadFailed += downloadFailed;
// Required local for iOS. Will cause runtime crash if inlined.
long onlineId = TrackedItem.OnlineID; long onlineId = TrackedItem.OnlineID;
long legacyOnlineId = TrackedItem.LegacyOnlineID; long legacyOnlineId = TrackedItem.LegacyOnlineID;
string hash = TrackedItem.Hash; string hash = TrackedItem.Hash;

1
osu.Game/Skinning/RealmBackedResourceStore.cs
View File

@ -29,6 +29,7 @@ namespace osu.Game.Skinning
invalidateCache(); invalidateCache();
Debug.Assert(fileToStoragePathMapping != null); Debug.Assert(fileToStoragePathMapping != null);
// Required local for iOS. Will cause runtime crash if inlined.
Guid id = source.ID; Guid id = source.ID;
realmSubscription = realm?.RegisterForNotifications(r => r.All<T>().Where(s => s.ID == id), skinChanged); realmSubscription = realm?.RegisterForNotifications(r => r.All<T>().Where(s => s.ID == id), skinChanged);

1
osu.Game/Skinning/SkinManager.cs
View File

@ -131,6 +131,7 @@ namespace osu.Game.Skinning
{ {
Realm.Run(r => Realm.Run(r =>
{ {
// Required local for iOS. Will cause runtime crash if inlined.
Guid currentSkinId = CurrentSkinInfo.Value.ID; Guid currentSkinId = CurrentSkinInfo.Value.ID;
// choose from only user skins, removing the current selection to ensure a new one is chosen. // choose from only user skins, removing the current selection to ensure a new one is chosen.