From 89b42ddd98f239ca605bf68311b4bc75a42babdc Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Thu, 16 Mar 2023 15:02:38 +0900
Subject: [PATCH] Don't localise beatmap count string for now

---
 osu.Game/Localisation/SongSelectStrings.cs |  5 -----
 osu.Game/Screens/Select/SongSelect.cs      | 11 +++++++++--
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/osu.Game/Localisation/SongSelectStrings.cs b/osu.Game/Localisation/SongSelectStrings.cs
index 046aec6bcf..e1ac328420 100644
--- a/osu.Game/Localisation/SongSelectStrings.cs
+++ b/osu.Game/Localisation/SongSelectStrings.cs
@@ -19,11 +19,6 @@ namespace osu.Game.Localisation
         /// </summary>
         public static LocalisableString LocallyModifiedTooltip => new TranslatableString(getKey(@"locally_modified_tooltip"), @"Has been locally modified");
 
-        /// <summary>
-        /// "{0} beatmaps displayed"
-        /// </summary>
-        public static LocalisableString BeatmapsDisplayed(int arg0) => new TranslatableString(getKey(@"beatmaps_displayed"), @"{0:#,0} beatmaps displayed", arg0);
-
         private static string getKey(string key) => $@"{prefix}:{key}";
     }
 }
diff --git a/osu.Game/Screens/Select/SongSelect.cs b/osu.Game/Screens/Select/SongSelect.cs
index 9f8c3f1a2c..a3521337ee 100644
--- a/osu.Game/Screens/Select/SongSelect.cs
+++ b/osu.Game/Screens/Select/SongSelect.cs
@@ -40,7 +40,6 @@ using osu.Game.Skinning;
 using osuTK;
 using osuTK.Graphics;
 using osuTK.Input;
-using osu.Game.Localisation;
 
 namespace osu.Game.Screens.Select
 {
@@ -163,7 +162,15 @@ namespace osu.Game.Screens.Select
                 BleedBottom = Footer.HEIGHT,
                 SelectionChanged = updateSelectedBeatmap,
                 BeatmapSetsChanged = carouselBeatmapsLoaded,
-                FilterApplied = () => FilterControl.InformationalText = SongSelectStrings.BeatmapsDisplayed(Carousel.CountDisplayed),
+                FilterApplied = () =>
+                {
+                    FilterControl.InformationalText =
+                        Carousel.CountDisplayed == 1
+                            // Intentionally not localised until we have proper support for this (see https://github.com/ppy/osu-framework/pull/4918
+                            // but also in this case we want support for formatting a number within a string).
+                            ? $"{Carousel.CountDisplayed:#,0} beatmap displayed"
+                            : $"{Carousel.CountDisplayed:#,0} beatmaps displayed";
+                },
                 GetRecommendedBeatmap = s => recommender?.GetRecommendedBeatmap(s),
             }, c => carouselContainer.Child = c);