From a0c33499352682b894fc8f84321badc3ca722107 Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Thu, 30 Nov 2017 00:45:37 +0900 Subject: [PATCH 1/9] Add LangVer.props and osu.Game.props for common csproj properties --- LangVer.props | 6 ++++++ osu.Desktop.Deploy/osu.Desktop.Deploy.csproj | 5 +---- osu.Desktop/osu.Desktop.csproj | 6 +----- osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj | 5 +---- osu.Game.Rulesets.Mania/osu.Game.Rulesets.Mania.csproj | 5 +---- osu.Game.Rulesets.Osu/osu.Game.Rulesets.Osu.csproj | 5 +---- osu.Game.Rulesets.Taiko/osu.Game.Rulesets.Taiko.csproj | 5 +---- osu.Game.Tests/osu.Game.Tests.csproj | 5 +---- osu.Game.props | 9 +++++++++ osu.Game/osu.Game.csproj | 5 +---- 10 files changed, 23 insertions(+), 33 deletions(-) create mode 100644 LangVer.props create mode 100644 osu.Game.props diff --git a/LangVer.props b/LangVer.props new file mode 100644 index 0000000000..2ff5e95378 --- /dev/null +++ b/LangVer.props @@ -0,0 +1,6 @@ + + + + 6 + + \ No newline at end of file diff --git a/osu.Desktop.Deploy/osu.Desktop.Deploy.csproj b/osu.Desktop.Deploy/osu.Desktop.Deploy.csproj index 6727a86a91..316d85db47 100644 --- a/osu.Desktop.Deploy/osu.Desktop.Deploy.csproj +++ b/osu.Desktop.Deploy/osu.Desktop.Deploy.csproj @@ -1,5 +1,6 @@  + Debug @@ -22,7 +23,6 @@ DEBUG;TRACE prompt 4 - 6 AnyCPU @@ -102,9 +102,6 @@ - - osu.licenseheader - PreserveNewest diff --git a/osu.Desktop/osu.Desktop.csproj b/osu.Desktop/osu.Desktop.csproj index 91c0da6f65..bf259c48ba 100644 --- a/osu.Desktop/osu.Desktop.csproj +++ b/osu.Desktop/osu.Desktop.csproj @@ -1,5 +1,6 @@  + {419659FD-72EA-4678-9EB8-B22A746CED70} Debug @@ -62,7 +63,6 @@ false - 6 none @@ -98,7 +98,6 @@ full AnyCPU false - 6 prompt --tests @@ -174,9 +173,6 @@ - - osu.licenseheader - diff --git a/osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj b/osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj index b7916f674e..b855e6178b 100644 --- a/osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj +++ b/osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj @@ -1,5 +1,6 @@  + Debug @@ -21,7 +22,6 @@ prompt 4 false - 6 pdbonly @@ -74,9 +74,6 @@ - - osu.licenseheader - diff --git a/osu.Game.Rulesets.Mania/osu.Game.Rulesets.Mania.csproj b/osu.Game.Rulesets.Mania/osu.Game.Rulesets.Mania.csproj index 19832d733e..b91f38cd3d 100644 --- a/osu.Game.Rulesets.Mania/osu.Game.Rulesets.Mania.csproj +++ b/osu.Game.Rulesets.Mania/osu.Game.Rulesets.Mania.csproj @@ -1,5 +1,6 @@  + Debug @@ -21,7 +22,6 @@ prompt 4 false - 6 pdbonly @@ -99,9 +99,6 @@ - - osu.licenseheader - diff --git a/osu.Game.Rulesets.Osu/osu.Game.Rulesets.Osu.csproj b/osu.Game.Rulesets.Osu/osu.Game.Rulesets.Osu.csproj index 2be057de40..05fb71afdf 100644 --- a/osu.Game.Rulesets.Osu/osu.Game.Rulesets.Osu.csproj +++ b/osu.Game.Rulesets.Osu/osu.Game.Rulesets.Osu.csproj @@ -1,5 +1,6 @@  + Debug @@ -22,7 +23,6 @@ prompt 4 false - 6 pdbonly @@ -105,9 +105,6 @@ - - osu.licenseheader - diff --git a/osu.Game.Rulesets.Taiko/osu.Game.Rulesets.Taiko.csproj b/osu.Game.Rulesets.Taiko/osu.Game.Rulesets.Taiko.csproj index 0b4e6e43f2..7b86fd921f 100644 --- a/osu.Game.Rulesets.Taiko/osu.Game.Rulesets.Taiko.csproj +++ b/osu.Game.Rulesets.Taiko/osu.Game.Rulesets.Taiko.csproj @@ -1,5 +1,6 @@  + Debug @@ -21,7 +22,6 @@ prompt 4 false - 6 pdbonly @@ -96,9 +96,6 @@ - - osu.licenseheader - diff --git a/osu.Game.Tests/osu.Game.Tests.csproj b/osu.Game.Tests/osu.Game.Tests.csproj index 312a564f71..8e7bfaa166 100644 --- a/osu.Game.Tests/osu.Game.Tests.csproj +++ b/osu.Game.Tests/osu.Game.Tests.csproj @@ -1,5 +1,6 @@  + Debug AnyCPU @@ -19,7 +20,6 @@ 4 false false - 6 true @@ -45,9 +45,6 @@ - - osu.licenseheader - diff --git a/osu.Game.props b/osu.Game.props new file mode 100644 index 0000000000..61d5bea511 --- /dev/null +++ b/osu.Game.props @@ -0,0 +1,9 @@ + + + + + + osu.licenseheader + + + \ No newline at end of file diff --git a/osu.Game/osu.Game.csproj b/osu.Game/osu.Game.csproj index ccd1bd03dc..aebd250489 100644 --- a/osu.Game/osu.Game.csproj +++ b/osu.Game/osu.Game.csproj @@ -1,5 +1,6 @@  + {2A66DD92-ADB1-4994-89E2-C94E04ACDA0D} Debug @@ -61,7 +62,6 @@ false - 6 none @@ -195,9 +195,6 @@ - - osu.licenseheader - From 006d67993905fac5c22f786cabc6f61134d58326 Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Thu, 30 Nov 2017 00:53:07 +0900 Subject: [PATCH 2/9] Migrate to C#7 --- LangVer.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LangVer.props b/LangVer.props index 2ff5e95378..e6a8b4b38c 100644 --- a/LangVer.props +++ b/LangVer.props @@ -1,6 +1,6 @@ - 6 + 7 \ No newline at end of file From 36be171c298d5c9aa43257d0b5b855d07b06bac9 Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Thu, 30 Nov 2017 02:06:03 +0900 Subject: [PATCH 3/9] Fix up/clean up csprojs for C#7 support --- LangVer.props | 4 +++- osu.Desktop.Deploy/osu.Desktop.Deploy.csproj | 3 +-- osu.Desktop/osu.Desktop.csproj | 2 +- osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj | 1 - osu.Game.Rulesets.Mania/osu.Game.Rulesets.Mania.csproj | 1 - osu.Game.Rulesets.Osu/osu.Game.Rulesets.Osu.csproj | 1 - osu.Game.Rulesets.Taiko/osu.Game.Rulesets.Taiko.csproj | 1 - osu.Game.Tests/osu.Game.Tests.csproj | 2 +- osu.Game.props | 2 +- osu.Game/osu.Game.csproj | 2 +- 10 files changed, 8 insertions(+), 11 deletions(-) diff --git a/LangVer.props b/LangVer.props index e6a8b4b38c..c3aee0505a 100644 --- a/LangVer.props +++ b/LangVer.props @@ -1,5 +1,7 @@ - + + + 7 diff --git a/osu.Desktop.Deploy/osu.Desktop.Deploy.csproj b/osu.Desktop.Deploy/osu.Desktop.Deploy.csproj index 316d85db47..3bec56d322 100644 --- a/osu.Desktop.Deploy/osu.Desktop.Deploy.csproj +++ b/osu.Desktop.Deploy/osu.Desktop.Deploy.csproj @@ -1,7 +1,6 @@  - - + Debug AnyCPU diff --git a/osu.Desktop/osu.Desktop.csproj b/osu.Desktop/osu.Desktop.csproj index bf259c48ba..e4e9807754 100644 --- a/osu.Desktop/osu.Desktop.csproj +++ b/osu.Desktop/osu.Desktop.csproj @@ -1,5 +1,5 @@  - + {419659FD-72EA-4678-9EB8-B22A746CED70} diff --git a/osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj b/osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj index b855e6178b..4605a1f50e 100644 --- a/osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj +++ b/osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj @@ -1,7 +1,6 @@  - Debug AnyCPU diff --git a/osu.Game.Rulesets.Mania/osu.Game.Rulesets.Mania.csproj b/osu.Game.Rulesets.Mania/osu.Game.Rulesets.Mania.csproj index b91f38cd3d..ec6f59b5be 100644 --- a/osu.Game.Rulesets.Mania/osu.Game.Rulesets.Mania.csproj +++ b/osu.Game.Rulesets.Mania/osu.Game.Rulesets.Mania.csproj @@ -1,7 +1,6 @@  - Debug AnyCPU diff --git a/osu.Game.Rulesets.Osu/osu.Game.Rulesets.Osu.csproj b/osu.Game.Rulesets.Osu/osu.Game.Rulesets.Osu.csproj index 05fb71afdf..5a0581f48b 100644 --- a/osu.Game.Rulesets.Osu/osu.Game.Rulesets.Osu.csproj +++ b/osu.Game.Rulesets.Osu/osu.Game.Rulesets.Osu.csproj @@ -1,7 +1,6 @@  - Debug AnyCPU diff --git a/osu.Game.Rulesets.Taiko/osu.Game.Rulesets.Taiko.csproj b/osu.Game.Rulesets.Taiko/osu.Game.Rulesets.Taiko.csproj index 7b86fd921f..72e9e6a061 100644 --- a/osu.Game.Rulesets.Taiko/osu.Game.Rulesets.Taiko.csproj +++ b/osu.Game.Rulesets.Taiko/osu.Game.Rulesets.Taiko.csproj @@ -1,7 +1,6 @@  - Debug AnyCPU diff --git a/osu.Game.Tests/osu.Game.Tests.csproj b/osu.Game.Tests/osu.Game.Tests.csproj index 8e7bfaa166..b4242052d5 100644 --- a/osu.Game.Tests/osu.Game.Tests.csproj +++ b/osu.Game.Tests/osu.Game.Tests.csproj @@ -1,5 +1,5 @@  - + Debug diff --git a/osu.Game.props b/osu.Game.props index 61d5bea511..4173adb509 100644 --- a/osu.Game.props +++ b/osu.Game.props @@ -1,5 +1,5 @@ - + diff --git a/osu.Game/osu.Game.csproj b/osu.Game/osu.Game.csproj index aebd250489..f814cbb3d3 100644 --- a/osu.Game/osu.Game.csproj +++ b/osu.Game/osu.Game.csproj @@ -1,5 +1,5 @@  - + {2A66DD92-ADB1-4994-89E2-C94E04ACDA0D} From 7451bdaa0ee56b82f5fd22af1016b203adc5b29d Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Thu, 30 Nov 2017 02:06:24 +0900 Subject: [PATCH 4/9] Update DotSettings --- osu.sln.DotSettings | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/osu.sln.DotSettings b/osu.sln.DotSettings index fdfbf25144..92ef2d1021 100644 --- a/osu.sln.DotSettings +++ b/osu.sln.DotSettings @@ -34,6 +34,7 @@ HINT WARNING WARNING + HINT WARNING WARNING DO_NOT_SHOW @@ -44,13 +45,16 @@ WARNING ERROR HINT + HINT HINT WARNING WARNING + DO_NOT_SHOW DO_NOT_SHOW HINT HINT HINT + HINT WARNING WARNING WARNING @@ -149,6 +153,7 @@ WARNING WARNING WARNING + HINT WARNING WARNING HINT From edb9b1907905ac6afefd62169cdbb8634df3669b Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Fri, 1 Dec 2017 13:53:18 +0900 Subject: [PATCH 5/9] Make JoinNullCheckWithAssignment a hint --- osu.sln.DotSettings | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.sln.DotSettings b/osu.sln.DotSettings index 92ef2d1021..76929dcbb3 100644 --- a/osu.sln.DotSettings +++ b/osu.sln.DotSettings @@ -49,7 +49,7 @@ HINT WARNING WARNING - DO_NOT_SHOW + HINT DO_NOT_SHOW HINT HINT From a73dfd692bd433f47f2847bbc385a46d62f30979 Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Fri, 1 Dec 2017 13:53:32 +0900 Subject: [PATCH 6/9] Merge LangVer.props and osu.Game.props --- LangVer.props | 8 -------- osu.Game.props | 6 +++++- 2 files changed, 5 insertions(+), 9 deletions(-) delete mode 100644 LangVer.props diff --git a/LangVer.props b/LangVer.props deleted file mode 100644 index c3aee0505a..0000000000 --- a/LangVer.props +++ /dev/null @@ -1,8 +0,0 @@ - - - - - - 7 - - \ No newline at end of file diff --git a/osu.Game.props b/osu.Game.props index 4173adb509..60a5e97944 100644 --- a/osu.Game.props +++ b/osu.Game.props @@ -1,6 +1,10 @@ - + + + + 7 + osu.licenseheader From 19051dd52962642c0323ce8d0355bcb529cc7845 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Fri, 1 Dec 2017 16:44:49 +0900 Subject: [PATCH 7/9] Update framework --- osu-framework | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu-framework b/osu-framework index 4fc866eee3..87d68cda00 160000 --- a/osu-framework +++ b/osu-framework @@ -1 +1 @@ -Subproject commit 4fc866eee3803f88b155150e32e021b9c21e647f +Subproject commit 87d68cda0015d51dc3da56d2322fa10d399fc4ed From 0b95e36675b2131ae7eb0ca5185678f8d432a627 Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Fri, 1 Dec 2017 18:00:20 +0900 Subject: [PATCH 8/9] Fix RelativeChildSize error temporarily --- .../Edit/Components/Timelines/Summary/Parts/TimelinePart.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/TimelinePart.cs b/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/TimelinePart.cs index 229d06ef09..8a19784be9 100644 --- a/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/TimelinePart.cs +++ b/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/TimelinePart.cs @@ -40,7 +40,7 @@ namespace osu.Game.Screens.Edit.Components.Timelines.Summary.Parts return; } - timeline.RelativeChildSize = new Vector2((float)Math.Max(1, Beatmap.Value.Track.Length), 1); + timeline.RelativeChildSize = Beatmap.Value.Track.Length == double.PositiveInfinity ? Vector2.One : new Vector2((float)Math.Max(1, Beatmap.Value.Track.Length), 1); } protected void Add(Drawable visualisation) => timeline.Add(visualisation); From 5be00cb0ecd9990a6c277a268725655d001775dd Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Fri, 1 Dec 2017 18:40:55 +0900 Subject: [PATCH 9/9] Add todo --- .../Edit/Components/Timelines/Summary/Parts/TimelinePart.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/TimelinePart.cs b/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/TimelinePart.cs index 8a19784be9..df95a5c384 100644 --- a/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/TimelinePart.cs +++ b/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/TimelinePart.cs @@ -40,6 +40,7 @@ namespace osu.Game.Screens.Edit.Components.Timelines.Summary.Parts return; } + // Todo: This should be handled more gracefully timeline.RelativeChildSize = Beatmap.Value.Track.Length == double.PositiveInfinity ? Vector2.One : new Vector2((float)Math.Max(1, Beatmap.Value.Track.Length), 1); }