h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-05 06:32:55 +08:00
Code Issues Releases Wiki Activity

Mention safety failures of Beatmap/Score constructors

Browse Source
This commit is contained in:
Dean Herbert 2022-01-10 13:25:23 +09:00
parent c831e9107a
commit 83ccbc1d13
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Beatmaps/BeatmapInfo.cs
View File

@ -74,7 +74,7 @@ namespace osu.Game.Beatmaps
} }
[UsedImplicitly] [UsedImplicitly]
public BeatmapInfo() public BeatmapInfo() // TODO: this bypasses null safeties. needs to be hidden from user api (only should be used by realm).
{ {
} }

13
osu.Game/Scoring/ScoreInfo.cs
View File

@ -4,6 +4,7 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using JetBrains.Annotations;
using Newtonsoft.Json; using Newtonsoft.Json;
using osu.Framework.Localisation; using osu.Framework.Localisation;
using osu.Framework.Testing; using osu.Framework.Testing;
@ -44,6 +45,18 @@ namespace osu.Game.Scoring
[MapTo("User")] [MapTo("User")]
public RealmUser RealmUser { get; set; } = null!; public RealmUser RealmUser { get; set; } = null!;
public ScoreInfo(BeatmapInfo beatmap, RulesetInfo ruleset, RealmUser user)
{
Ruleset = ruleset;
Beatmap = beatmap;
RealmUser = user;
}
[UsedImplicitly]
public ScoreInfo() // TODO: this bypasses null safeties. needs to be hidden from user api (only should be used by realm).
{
}
// TODO: this is a bit temporary to account for the fact that this class is used to ferry API user data to certain UI components. // TODO: this is a bit temporary to account for the fact that this class is used to ferry API user data to certain UI components.
// Eventually we should either persist enough information to realm to not require the API lookups, or perform the API lookups locally. // Eventually we should either persist enough information to realm to not require the API lookups, or perform the API lookups locally.
private APIUser? user; private APIUser? user;