h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-10 21:40:34 +08:00
Code Issues Releases Wiki Activity

Merge pull request #32085 from bdach/i-dont-even

Browse Source 
Fix taiko swell ending samples playing at results sometimes
This commit is contained in:
Dan Balasescu 2025-02-25 12:31:59 +09:00 committed by GitHub
commit 820821d6c7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs
View File

@ -247,7 +247,12 @@ namespace osu.Game.Rulesets.UI.Scrolling
// It is required that we set a lifetime end here to ensure that in scenarios like loading a Player instance to a seeked
// location in a beatmap doesn't churn every hit object into a DrawableHitObject. Even in a pooled scenario, the overhead
// of this can be quite crippling.
entry.LifetimeEnd = entry.HitObject.GetEndTime() + timeRange.Value;
//
// However, additionally do not attempt to alter lifetime of judged entries.
// This is to prevent freak accidents like objects suddenly becoming alive because of this estimate assigning a later lifetime
// than the object itself decided it should have when it underwent judgement.
if (!entry.Judged)
entry.LifetimeEnd = entry.HitObject.GetEndTime() + timeRange.Value;
}
private void updateLayoutRecursive(DrawableHitObject hitObject, double? parentHitObjectStartTime = null)