h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-05 05:43:21 +08:00
Code Issues Releases Wiki Activity

Cache reflection portion of SettingSource lookups

Browse Source 
Fixes the mod-related overhead portion of https://github.com/ppy/osu/issues/14638. There's still a significant performance issue that will be addressed separately.
This commit is contained in:
Dean Herbert 2021-09-08 13:26:07 +09:00
parent 2c6ee0ebf7
commit 81c9d831f4
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
osu.Game/Configuration/SettingSourceAttribute.cs
View File

@ -167,18 +167,7 @@ namespace osu.Game.Configuration
} }
} }
public static IEnumerable<(SettingSourceAttribute, PropertyInfo)> GetSettingsSourceProperties(this object obj) public static IEnumerable<(SettingSourceAttribute, PropertyInfo)> GetSettingsSourceProperties<T>(this T obj) => SettingSourceCache<T>.SettingSourceProperties;
{
foreach (var property in obj.GetType().GetProperties(BindingFlags.GetProperty | BindingFlags.Public | BindingFlags.Instance))
{
var attr = property.GetCustomAttribute<SettingSourceAttribute>(true);
if (attr == null)
continue;
yield return (attr, property);
}
}
public static ICollection<(SettingSourceAttribute, PropertyInfo)> GetOrderedSettingsSourceProperties(this object obj) public static ICollection<(SettingSourceAttribute, PropertyInfo)> GetOrderedSettingsSourceProperties(this object obj)
=> obj.GetSettingsSourceProperties() => obj.GetSettingsSourceProperties()
@ -196,5 +185,14 @@ namespace osu.Game.Configuration
protected override DropdownMenu CreateMenu() => base.CreateMenu().With(m => m.MaxHeight = 100); protected override DropdownMenu CreateMenu() => base.CreateMenu().With(m => m.MaxHeight = 100);
} }
} }
private static class SettingSourceCache<T>
{
public static (SettingSourceAttribute, PropertyInfo)[] SettingSourceProperties { get; } =
typeof(T).GetProperties(BindingFlags.GetProperty | BindingFlags.Public | BindingFlags.Instance)
.Select(property => (property.GetCustomAttribute<SettingSourceAttribute>(), property))
.Where(pair => pair.Item1 != null)
.ToArray();
}
} }
} }