From 8185020f128dcda5d5a1feb236b02e7a3fbd51d7 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Mon, 4 Apr 2022 20:35:48 +0900
Subject: [PATCH] Improve the visual of the missing sprite sprite

---
 osu.Game/Skinning/RealmBackedResourceStore.cs |  1 -
 osu.Game/Skinning/SkinnableSprite.cs          | 33 +++++++++++++++----
 2 files changed, 26 insertions(+), 8 deletions(-)

diff --git a/osu.Game/Skinning/RealmBackedResourceStore.cs b/osu.Game/Skinning/RealmBackedResourceStore.cs
index 0353b8a64d..0057132044 100644
--- a/osu.Game/Skinning/RealmBackedResourceStore.cs
+++ b/osu.Game/Skinning/RealmBackedResourceStore.cs
@@ -7,7 +7,6 @@ using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
-using System.Threading;
 using osu.Framework.Extensions;
 using osu.Framework.IO.Stores;
 using osu.Game.Database;
diff --git a/osu.Game/Skinning/SkinnableSprite.cs b/osu.Game/Skinning/SkinnableSprite.cs
index e7c62302b1..c5f110f908 100644
--- a/osu.Game/Skinning/SkinnableSprite.cs
+++ b/osu.Game/Skinning/SkinnableSprite.cs
@@ -6,9 +6,11 @@ using System.Linq;
 using osu.Framework.Allocation;
 using osu.Framework.Bindables;
 using osu.Framework.Graphics;
+using osu.Framework.Graphics.Containers;
 using osu.Framework.Graphics.Sprites;
 using osu.Framework.Graphics.Textures;
 using osu.Game.Configuration;
+using osu.Game.Graphics.Sprites;
 using osu.Game.Overlays.Settings;
 using osuTK;
 
@@ -55,13 +57,7 @@ namespace osu.Game.Skinning
             var texture = textures.Get(component.LookupName);
 
             if (texture == null)
-            {
-                return new SpriteIcon
-                {
-                    Size = new Vector2(100),
-                    Icon = FontAwesome.Solid.QuestionCircle
-                };
-            }
+                return new SpriteNotFound(component.LookupName);
 
             return new Sprite { Texture = texture };
         }
@@ -98,5 +94,28 @@ namespace osu.Game.Skinning
                     Items = availableFiles;
             }
         }
+
+        public class SpriteNotFound : CompositeDrawable
+        {
+            public SpriteNotFound(string lookup)
+            {
+                AutoSizeAxes = Axes.Both;
+
+                InternalChildren = new Drawable[]
+                {
+                    new SpriteIcon
+                    {
+                        Size = new Vector2(50),
+                        Icon = FontAwesome.Solid.QuestionCircle
+                    },
+                    new OsuSpriteText
+                    {
+                        Position = new Vector2(25, 50),
+                        Text = $"missing: {lookup}",
+                        Origin = Anchor.TopCentre,
+                    }
+                };
+            }
+        }
     }
 }