From 7ec67c28b90d8bd0d197026f8fdf6a571d00c6a0 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Thu, 11 Aug 2022 14:35:55 +0900
Subject: [PATCH] Set `Online` state sooner in connection process

This isn't really required as such, but feels more correct. There was no
reason for it to wait for the friend population to complete before
deeming things to be "online".
---
 osu.Game/Online/API/APIAccess.cs | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/osu.Game/Online/API/APIAccess.cs b/osu.Game/Online/API/APIAccess.cs
index 66bd22df52..f353c48f03 100644
--- a/osu.Game/Online/API/APIAccess.cs
+++ b/osu.Game/Online/API/APIAccess.cs
@@ -195,6 +195,8 @@ namespace osu.Game.Online.API
 
                             setLocalUser(user);
 
+                            //we're connected!
+                            state.Value = APIState.Online;
                             failureCount = 0;
                         };
 
@@ -208,13 +210,7 @@ namespace osu.Game.Online.API
                         var friendsReq = new GetFriendsRequest();
 
                         friendsReq.Failure += _ => failConnectionProcess();
-                        friendsReq.Success += res =>
-                        {
-                            friends.AddRange(res);
-
-                            //we're connected!
-                            state.Value = APIState.Online;
-                        };
+                        friendsReq.Success += res => friends.AddRange(res);
 
                         if (!handleRequest(friendsReq))
                         {