1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 20:22:55 +08:00

Review fixes

This commit is contained in:
Dean Herbert 2017-08-21 23:34:08 +09:00
parent 1d0b89d592
commit 7d1c270126
2 changed files with 1 additions and 2 deletions

View File

@ -79,7 +79,7 @@ namespace osu.Game.Online.Chat
public void ReplaceMessage(LocalEchoMessage echo, Message final) public void ReplaceMessage(LocalEchoMessage echo, Message final)
{ {
if (!pendingMessages.Remove(echo)) if (!pendingMessages.Remove(echo))
Trace.Fail("Attempted to remove echo that wasn't present"); throw new InvalidOperationException("Attempted to remove echo that wasn't present");
Messages.Remove(echo); Messages.Remove(echo);

View File

@ -44,7 +44,6 @@ namespace osu.Game.Online.Chat
public int CompareTo(Message other) public int CompareTo(Message other)
{ {
if (!Id.HasValue) if (!Id.HasValue)
return other.Id.HasValue ? 1 : Timestamp.CompareTo(other.Timestamp); return other.Id.HasValue ? 1 : Timestamp.CompareTo(other.Timestamp);
if (!other.Id.HasValue) if (!other.Id.HasValue)