h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-22 08:32:54 +08:00
Code Issues Releases Wiki Activity

Merge pull request #8562 from mcendu/mania-fallback-to-head

Browse Source 
Allow hold note tail to fallback to normal note image
This commit is contained in:
Dan Balasescu 2020-04-02 16:37:45 +09:00 committed by GitHub
commit 7c428011a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
osu.Game.Rulesets.Mania/Skinning/LegacyHoldNoteHeadPiece.cs
View File

@ -10,6 +10,7 @@ namespace osu.Game.Rulesets.Mania.Skinning
{ {
protected override Texture GetTexture(ISkinSource skin) protected override Texture GetTexture(ISkinSource skin)
{ {
// TODO: Should fallback to the head from default legacy skin instead of note.
return GetTextureFromLookup(skin, LegacyManiaSkinConfigurationLookups.HoldNoteHeadImage) return GetTextureFromLookup(skin, LegacyManiaSkinConfigurationLookups.HoldNoteHeadImage)
?? GetTextureFromLookup(skin, LegacyManiaSkinConfigurationLookups.NoteImage); ?? GetTextureFromLookup(skin, LegacyManiaSkinConfigurationLookups.NoteImage);
} }

4
osu.Game.Rulesets.Mania/Skinning/LegacyHoldNoteTailPiece.cs
View File

@ -20,8 +20,10 @@ namespace osu.Game.Rulesets.Mania.Skinning
protected override Texture GetTexture(ISkinSource skin) protected override Texture GetTexture(ISkinSource skin)
{ {
// TODO: Should fallback to the head from default legacy skin instead of note.
return GetTextureFromLookup(skin, LegacyManiaSkinConfigurationLookups.HoldNoteTailImage) return GetTextureFromLookup(skin, LegacyManiaSkinConfigurationLookups.HoldNoteTailImage)
?? GetTextureFromLookup(skin, LegacyManiaSkinConfigurationLookups.HoldNoteHeadImage); ?? GetTextureFromLookup(skin, LegacyManiaSkinConfigurationLookups.HoldNoteHeadImage)
?? GetTextureFromLookup(skin, LegacyManiaSkinConfigurationLookups.NoteImage);
} }
} }
} }