h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-29 05:43:21 +08:00
Code Issues Releases Wiki Activity

Add back PerformRead return safety by checking IsManaged status of returned data

Browse Source
This commit is contained in:
Dean Herbert 2022-01-13 13:14:44 +09:00
parent 085893c9b4
commit 7baff18764
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
osu.Game/Database/RealmLive.cs
View File

@ -61,15 +61,18 @@ namespace osu.Game.Database
/// <param name="perform">The action to perform.</param> /// <param name="perform">The action to perform.</param>
public TReturn PerformRead<TReturn>(Func<T, TReturn> perform) public TReturn PerformRead<TReturn>(Func<T, TReturn> perform)
{ {
// TODO: this is weird and kinda wrong... unmanaged objects should be allowed?
// if (typeof(RealmObjectBase).IsAssignableFrom(typeof(TReturn)))
// throw new InvalidOperationException(@$"Realm live objects should not exit the scope of {nameof(PerformRead)}.");
if (!IsManaged) if (!IsManaged)
return perform(data); return perform(data);
using (var realm = realmFactory.CreateContext()) using (var realm = realmFactory.CreateContext())
return perform(realm.Find<T>(ID)); {
var returnData = perform(realm.Find<T>(ID));
if (returnData is RealmObjectBase realmObject && realmObject.IsManaged)
throw new InvalidOperationException(@$"Managed realm objects should not exit the scope of {nameof(PerformRead)}.");
return returnData;
}
} }
/// <summary> /// <summary>