h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-05 10:13:00 +08:00
Code Issues Releases Wiki Activity

Fix negative replay frames being played back incorrectly

Browse Source
This commit is contained in:
Dean Herbert 2020-01-30 14:54:57 +09:00
parent 2beb10b860
commit 7b4a658264
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game/Scoring/Legacy/LegacyScoreParser.cs
View File

@ -220,9 +220,11 @@ namespace osu.Game.Scoring.Legacy
float lastTime = 0; float lastTime = 0;
ReplayFrame currentFrame = null; ReplayFrame currentFrame = null;
foreach (var l in reader.ReadToEnd().Split(',')) var frames = reader.ReadToEnd().Split(',');
for (var i = 0; i < frames.Length; i++)
{ {
var split = l.Split('|'); var split = frames[i].Split('|');
if (split.Length < 4) if (split.Length < 4)
continue; continue;
@ -234,8 +236,14 @@ namespace osu.Game.Scoring.Legacy
} }
var diff = Parsing.ParseFloat(split[0]); var diff = Parsing.ParseFloat(split[0]);
lastTime += diff; lastTime += diff;
if (i == 0 && diff == 0)
// osu-stable adds a zero-time frame before potentially valid negative user frames.
// we need to ignroe this.
continue;
// Todo: At some point we probably want to rewind and play back the negative-time frames // Todo: At some point we probably want to rewind and play back the negative-time frames
// but for now we'll achieve equal playback to stable by skipping negative frames // but for now we'll achieve equal playback to stable by skipping negative frames
if (diff < 0) if (diff < 0)