h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-14 20:32:55 +08:00
Code Issues Releases Wiki Activity

Refactor tick calculation code for readability

Browse Source
This commit is contained in:
Bartłomiej Dach 2020-11-23 21:38:04 +01:00
parent bb5aa9a9c9
commit 7b0d3dfe0c
1 changed files with 21 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
osu.Game/Overlays/Profile/Sections/Historical/ProfileLineChart.cs
View File

@ -117,7 +117,7 @@ namespace osu.Game.Overlays.Profile.Sections.Historical
var min = values.Select(v => v.Count).Min(); var min = values.Select(v => v.Count).Min();
var max = values.Select(v => v.Count).Max(); var max = values.Select(v => v.Count).Max();
var tick = getTick(max - min, 6); var tick = getTickInterval(max - min, 6);
// Prevent infinite loop in case if tick is zero // Prevent infinite loop in case if tick is zero
if (tick == 0) if (tick == 0)
@ -208,25 +208,32 @@ namespace osu.Game.Overlays.Profile.Sections.Historical
}); });
} }
private long getTick(long range, int maxTicksCount) private long getTickInterval(long range, int maxTicksCount)
{ {
var value = (float)range / (maxTicksCount - 1); // this interval is what would be achieved if the interval was divided perfectly evenly into maxTicksCount ticks.
// can contain ugly fractional parts.
var exactTickInterval = (float)range / (maxTicksCount - 1);
var exponent = Math.Floor(Math.Log10(value)); // the ideal ticks start with a 1, 2 or 5, and are multipliers of powers of 10.
var fraction = value / Math.Pow(10, exponent); // first off, use log10 to calculate the number of digits in the "exact" interval.
var numberOfDigits = Math.Floor(Math.Log10(exactTickInterval));
var tickBase = Math.Pow(10, numberOfDigits);
// then see how the exact tick relates to the power of 10.
var exactTickMultiplier = exactTickInterval / tickBase;
double niceFraction; double tickMultiplier;
if (fraction < 1.5) // round up the fraction to start with a 1, 2 or 5. closest match wins.
niceFraction = 1.0; if (exactTickMultiplier < 1.5)
else if (fraction < 3) tickMultiplier = 1.0;
niceFraction = 2.0; else if (exactTickMultiplier < 3)
else if (fraction < 7) tickMultiplier = 2.0;
niceFraction = 5.0; else if (exactTickMultiplier < 7)
tickMultiplier = 5.0;
else else
niceFraction = 10.0; tickMultiplier = 10.0;
return (long)(niceFraction * Math.Pow(10, exponent)); return Math.Max((long)(tickMultiplier * tickBase), 1);
} }
private class TickText : OsuSpriteText private class TickText : OsuSpriteText