h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 10:12:54 +08:00
Code Issues Releases Wiki Activity

Add some notes

Browse Source
This commit is contained in:
Dan Balasescu 2023-11-10 19:09:09 +09:00
parent 12e5766d50
commit 793d90e396
No known key found for this signature in database
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game.Rulesets.Osu/Scoring/OsuHealthProcessor.cs
View File

@ -64,6 +64,7 @@ namespace osu.Game.Rulesets.Osu.Scoring
double localLastTime = lastTime; double localLastTime = lastTime;
double breakTime = 0; double breakTime = 0;
// TODO: This doesn't handle overlapping/sequential breaks correctly (/b/614).
// Subtract any break time from the duration since the last object // Subtract any break time from the duration since the last object
if (Beatmap.Breaks.Count > 0 && currentBreak < Beatmap.Breaks.Count) if (Beatmap.Breaks.Count > 0 && currentBreak < Beatmap.Breaks.Count)
{ {
@ -107,6 +108,8 @@ namespace osu.Game.Rulesets.Osu.Scoring
increaseHp(nested); increaseHp(nested);
} }
// Note: Because HP is capped during the above increases, long sliders (with many ticks) or spinners
// will appear to overkill at lower drain levels than they should. However, it is also not correct to simply use the uncapped version.
if (hpOverkill > 0 && currentHp - hpOverkill <= lowestHpEver) if (hpOverkill > 0 && currentHp - hpOverkill <= lowestHpEver)
{ {
fail = true; fail = true;