h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-06 07:02:54 +08:00
Code Issues Releases Wiki Activity

Rename and xmldoc members

Browse Source
This commit is contained in:
Bartłomiej Dach 2023-06-22 23:00:52 +02:00
parent 21bed336c6
commit 786deec296
No known key found for this signature in database
4 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game.Tests/Visual/UserInterface/TestSceneCommentEditor.cs
View File

@ -160,7 +160,7 @@ namespace osu.Game.Tests.Visual.UserInterface
protected override LocalisableString FooterText => @"Footer text. And it is pretty long. Cool."; protected override LocalisableString FooterText => @"Footer text. And it is pretty long. Cool.";
protected override LocalisableString GetCommitButtonText(bool isLoggedIn) => protected override LocalisableString GetButtonText(bool isLoggedIn) =>
isLoggedIn ? @"Commit" : "You're logged out!"; isLoggedIn ? @"Commit" : "You're logged out!";
protected override LocalisableString GetPlaceholderText(bool isLoggedIn) => protected override LocalisableString GetPlaceholderText(bool isLoggedIn) =>
@ -184,7 +184,7 @@ namespace osu.Game.Tests.Visual.UserInterface
{ {
} }
protected override LocalisableString GetCommitButtonText(bool isLoggedIn) => @"Save"; protected override LocalisableString GetButtonText(bool isLoggedIn) => @"Save";
protected override LocalisableString GetPlaceholderText(bool isLoggedIn) => @"Multiline textboxes soon"; protected override LocalisableString GetPlaceholderText(bool isLoggedIn) => @"Multiline textboxes soon";
} }
} }

15
osu.Game/Overlays/Comments/CommentEditor.cs
View File

@ -44,8 +44,17 @@ namespace osu.Game.Overlays.Comments
[Resolved] [Resolved]
private LoginOverlay? loginOverlay { get; set; } private LoginOverlay? loginOverlay { get; set; }
protected abstract LocalisableString GetCommitButtonText(bool isLoggedIn); /// <summary>
/// Returns the text content of the main action button.
/// When <paramref name="isLoggedIn"/> is <see langword="true"/>, the text will apply to a button that posts a comment.
/// When <paramref name="isLoggedIn"/> is <see langword="false"/>, the text will apply to a button that directs the user to the login overlay.
/// </summary>
protected abstract LocalisableString GetButtonText(bool isLoggedIn);
/// <summary>
/// Returns the placeholder text for the comment box.
/// </summary>
/// <param name="isLoggedIn">Whether the current user is logged in.</param>
protected abstract LocalisableString GetPlaceholderText(bool isLoggedIn); protected abstract LocalisableString GetPlaceholderText(bool isLoggedIn);
protected bool ShowLoadingSpinner protected bool ShowLoadingSpinner
@ -128,13 +137,13 @@ namespace osu.Game.Overlays.Comments
commitButton = new EditorButton commitButton = new EditorButton
{ {
Action = () => OnCommit(Current.Value), Action = () => OnCommit(Current.Value),
Text = GetCommitButtonText(true) Text = GetButtonText(true)
}, },
logInButton = new EditorButton logInButton = new EditorButton
{ {
Width = 100, Width = 100,
Action = () => loginOverlay?.Show(), Action = () => loginOverlay?.Show(),
Text = GetCommitButtonText(false) Text = GetButtonText(false)
} }
} }
}, },

2
osu.Game/Overlays/Comments/CommentsContainer.cs
View File

@ -410,7 +410,7 @@ namespace osu.Game.Overlays.Comments
//TODO should match web, left empty due to no multiline support //TODO should match web, left empty due to no multiline support
protected override LocalisableString FooterText => default; protected override LocalisableString FooterText => default;
protected override LocalisableString GetCommitButtonText(bool isLoggedIn) => protected override LocalisableString GetButtonText(bool isLoggedIn) =>
isLoggedIn ? CommonStrings.ButtonsPost : CommentsStrings.GuestButtonNew; isLoggedIn ? CommonStrings.ButtonsPost : CommentsStrings.GuestButtonNew;
protected override LocalisableString GetPlaceholderText(bool isLoggedIn) => protected override LocalisableString GetPlaceholderText(bool isLoggedIn) =>

2
osu.Game/Overlays/Comments/ReplyCommentEditor.cs
View File

@ -23,7 +23,7 @@ namespace osu.Game.Overlays.Comments
protected override LocalisableString FooterText => default; protected override LocalisableString FooterText => default;
protected override LocalisableString GetCommitButtonText(bool isLoggedIn) => protected override LocalisableString GetButtonText(bool isLoggedIn) =>
isLoggedIn ? CommonStrings.ButtonsReply : CommentsStrings.GuestButtonReply; isLoggedIn ? CommonStrings.ButtonsReply : CommentsStrings.GuestButtonReply;
protected override LocalisableString GetPlaceholderText(bool isLoggedIn) => protected override LocalisableString GetPlaceholderText(bool isLoggedIn) =>