mirror of
https://github.com/ppy/osu.git
synced 2024-12-14 20:13:21 +08:00
Improve exception when attempting to call DrawableHitObject.ClearInternal
This commit is contained in:
parent
2bdc6417e9
commit
78625fda7d
@ -172,7 +172,7 @@ namespace osu.Game.Rulesets.Objects.Drawables
|
|||||||
{
|
{
|
||||||
config.BindWith(OsuSetting.PositionalHitsoundsLevel, positionalHitsoundsLevel);
|
config.BindWith(OsuSetting.PositionalHitsoundsLevel, positionalHitsoundsLevel);
|
||||||
|
|
||||||
// Explicit non-virtual function call.
|
// Explicit non-virtual function call in case a DrawableHitObject overrides AddInternal.
|
||||||
base.AddInternal(Samples = new PausableSkinnableSound());
|
base.AddInternal(Samples = new PausableSkinnableSound());
|
||||||
|
|
||||||
CurrentSkin = skinSource;
|
CurrentSkin = skinSource;
|
||||||
@ -405,7 +405,10 @@ namespace osu.Game.Rulesets.Objects.Drawables
|
|||||||
/// </summary>
|
/// </summary>
|
||||||
public event Action<DrawableHitObject, ArmedState> ApplyCustomUpdateState;
|
public event Action<DrawableHitObject, ArmedState> ApplyCustomUpdateState;
|
||||||
|
|
||||||
protected override void ClearInternal(bool disposeChildren = true) => throw new InvalidOperationException($"Should never clear a {nameof(DrawableHitObject)}");
|
protected override void ClearInternal(bool disposeChildren = true) =>
|
||||||
|
// See sample addition in load method.
|
||||||
|
throw new InvalidOperationException(
|
||||||
|
$"Should never clear a {nameof(DrawableHitObject)} as the base implementation adds components. If attempting to use {nameof(InternalChild)} or {nameof(InternalChildren)}, using {nameof(AddInternal)} or {nameof(AddRangeInternal)} instead.");
|
||||||
|
|
||||||
private void updateState(ArmedState newState, bool force = false)
|
private void updateState(ArmedState newState, bool force = false)
|
||||||
{
|
{
|
||||||
|
Loading…
Reference in New Issue
Block a user