From 748003b016ce84bf4d0f13f98a70ed494cbb8915 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Fri, 29 Oct 2021 11:54:19 +0900
Subject: [PATCH] Simplify `Manager` null check to a single pre-check

---
 osu.Game/Online/BeatmapDownloadTracker.cs | 26 +++++++++++------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/osu.Game/Online/BeatmapDownloadTracker.cs b/osu.Game/Online/BeatmapDownloadTracker.cs
index 181968c02f..4a7d0b660a 100644
--- a/osu.Game/Online/BeatmapDownloadTracker.cs
+++ b/osu.Game/Online/BeatmapDownloadTracker.cs
@@ -31,25 +31,25 @@ namespace osu.Game.Online
         [BackgroundDependencyLoader(true)]
         private void load()
         {
+            if (Manager == null)
+                return;
+
             // Used to interact with manager classes that don't support interface types. Will eventually be replaced.
             var beatmapSetInfo = new BeatmapSetInfo { OnlineBeatmapSetID = TrackedItem.OnlineID };
 
-            if (Manager?.IsAvailableLocally(beatmapSetInfo) == true)
+            if (Manager.IsAvailableLocally(beatmapSetInfo))
                 UpdateState(DownloadState.LocallyAvailable);
-            else if (Manager != null)
+            else
                 attachDownload(Manager.GetExistingDownload(beatmapSetInfo));
 
-            if (Manager != null)
-            {
-                managerDownloadBegan = Manager.DownloadBegan.GetBoundCopy();
-                managerDownloadBegan.BindValueChanged(downloadBegan);
-                managerDownloadFailed = Manager.DownloadFailed.GetBoundCopy();
-                managerDownloadFailed.BindValueChanged(downloadFailed);
-                managerUpdated = Manager.ItemUpdated.GetBoundCopy();
-                managerUpdated.BindValueChanged(itemUpdated);
-                managerRemoved = Manager.ItemRemoved.GetBoundCopy();
-                managerRemoved.BindValueChanged(itemRemoved);
-            }
+            managerDownloadBegan = Manager.DownloadBegan.GetBoundCopy();
+            managerDownloadBegan.BindValueChanged(downloadBegan);
+            managerDownloadFailed = Manager.DownloadFailed.GetBoundCopy();
+            managerDownloadFailed.BindValueChanged(downloadFailed);
+            managerUpdated = Manager.ItemUpdated.GetBoundCopy();
+            managerUpdated.BindValueChanged(itemUpdated);
+            managerRemoved = Manager.ItemRemoved.GetBoundCopy();
+            managerRemoved.BindValueChanged(itemRemoved);
         }
 
         private void downloadBegan(ValueChangedEvent<WeakReference<ArchiveDownloadRequest<BeatmapSetInfo>>> weakRequest)