From 7407efeea5e2fda55f4ea03eb6bd21a7737b1b89 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Mon, 28 Jul 2025 10:59:30 +0200 Subject: [PATCH] Add failing test coverage --- .../TestSceneBeatmapTitleWedge.cs | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/osu.Game.Tests/Visual/SongSelectV2/TestSceneBeatmapTitleWedge.cs b/osu.Game.Tests/Visual/SongSelectV2/TestSceneBeatmapTitleWedge.cs index 2ff677becd..efd9f6a5cd 100644 --- a/osu.Game.Tests/Visual/SongSelectV2/TestSceneBeatmapTitleWedge.cs +++ b/osu.Game.Tests/Visual/SongSelectV2/TestSceneBeatmapTitleWedge.cs @@ -18,6 +18,7 @@ using osu.Framework.Testing; using osu.Game.Beatmaps; using osu.Game.Beatmaps.ControlPoints; using osu.Game.Beatmaps.Drawables; +using osu.Game.Graphics.UserInterface; using osu.Game.Online.API; using osu.Game.Online.API.Requests; using osu.Game.Online.API.Requests.Responses; @@ -246,6 +247,7 @@ namespace osu.Game.Tests.Visual.SongSelectV2 { var (working, onlineSet) = createTestBeatmap(); onlineSet.FavouriteCount = 9999; + onlineSet.HasFavourited = true; working.BeatmapSetInfo.OnlineID = onlineSet.OnlineID = 99999; currentOnlineSet = onlineSet; @@ -253,6 +255,42 @@ namespace osu.Game.Tests.Visual.SongSelectV2 }); AddStep("allow request to complete", () => resetEvent.Set()); AddAssert("favourites count = 9999", () => this.ChildrenOfType().Single().Text.ToString() == "9,999"); + + AddStep("set up request handler to fail", () => + { + ((DummyAPIAccess)API).HandleRequest = request => + { + switch (request) + { + case GetBeatmapSetRequest set: + if (set.ID == currentOnlineSet?.OnlineID) + { + set.TriggerSuccess(currentOnlineSet); + return true; + } + + return false; + + case PostBeatmapFavouriteRequest favourite: + Task.Run(() => + { + resetEvent.Wait(10000); + favourite.TriggerFailure(new APIException("You have too many favourited beatmaps! Please unfavourite some before trying again.", null)); + }); + return true; + + default: + return false; + } + }; + }); + AddStep("reset event", () => resetEvent.Reset()); + AddStep("click favourite button", () => this.ChildrenOfType().Single().TriggerClick()); + AddAssert("spinner visible", () => this.ChildrenOfType().Single() + .ChildrenOfType().Single().State.Value, () => Is.EqualTo(Visibility.Visible)); + AddStep("allow request to complete", () => resetEvent.Set()); + AddAssert("spinner hidden", () => this.ChildrenOfType().Single() + .ChildrenOfType().Single().State.Value, () => Is.EqualTo(Visibility.Hidden)); } [TestCase(120, 125, null, "120-125 (mostly 120)")]