h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-06 20:22:56 +08:00
Code Issues Releases Wiki Activity

Remove BindableVolume.Value

Browse Source 
Getter can be replaced with explicit calls to Real

Setter should instead be a function with a clearer name.
This commit is contained in:
Mike Will 2025-01-13 11:48:52 -05:00
parent d7d536ada1
commit 72ef33554a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Screens/Play/PlayerLoader.cs
View File

@ -650,7 +650,7 @@ namespace osu.Game.Screens.Play
{ {
if (!muteWarningShownOnce.Value) if (!muteWarningShownOnce.Value)
{ {
double aggregateVolumeTrack = audioManager.Volume.Value * audioManager.VolumeTrack.Value; double aggregateVolumeTrack = audioManager.Volume.Real.Value * audioManager.VolumeTrack.Real.Value;
// Checks if the notification has not been shown yet and also if master volume is muted, track/music volume is muted or if the whole game is muted. // Checks if the notification has not been shown yet and also if master volume is muted, track/music volume is muted or if the whole game is muted.
if (volumeOverlay?.IsMuted.Value == true || Precision.AlmostBigger(volume_requirement, aggregateVolumeTrack)) if (volumeOverlay?.IsMuted.Value == true || Precision.AlmostBigger(volume_requirement, aggregateVolumeTrack))
@ -684,8 +684,8 @@ namespace osu.Game.Screens.Play
// Check values before resetting, as the user may have only had mute enabled, in which case we might not need to adjust volumes. // Check values before resetting, as the user may have only had mute enabled, in which case we might not need to adjust volumes.
// Note that we only restore halfway to ensure the user isn't suddenly overloaded by unexpectedly high volume. // Note that we only restore halfway to ensure the user isn't suddenly overloaded by unexpectedly high volume.
audioManager.Volume.Value = Math.Max(audioManager.Volume.Value, 0.5); audioManager.Volume.SetFromLinear(Math.Max(audioManager.Volume.Real.Value, 0.5));
audioManager.VolumeTrack.Value = Math.Max(audioManager.VolumeTrack.Value, 0.5); audioManager.VolumeTrack.SetFromLinear(Math.Max(audioManager.VolumeTrack.Real.Value, 0.5));
return true; return true;
}; };